Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions and typing for HTML attributes #30

Closed
joffrey-bion opened this issue Jan 16, 2021 · 0 comments
Closed

Extensions and typing for HTML attributes #30

joffrey-bion opened this issue Jan 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented Jan 16, 2021 •
edited
Loading

The API for HTML attributes in the protocol is pretty bad.
It returns the attributes as a list of strings in the form [key1, value1, key2, value2].

We can do better by providing a Map<String, String> and maybe even a proper type with typed properties for common HTML attributes.
@joffrey-bion joffrey-bion added the enhancement New feature or request label Jan 16, 2021
joffrey-bion added a commit that referenced this issue Jan 17, 2021
@joffrey-bion
Add DOM extensions to retrieve attributes in a decent manner
d816035 
Resolves:
#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion