Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url and faviconUrl properties to ChromeDPTarget #305

Closed
joffrey-bion opened this issue Oct 8, 2023 Discussed in #304 · 0 comments
Closed

Add url and faviconUrl properties to ChromeDPTarget #305

joffrey-bion opened this issue Oct 8, 2023 Discussed in #304 · 0 comments
Labels
enhancement New feature or request

Comments

@joffrey-bion
Copy link
Owner

Discussed in #304

Originally posted by bulletjet786 October 7, 2023
chrome-devtools-kotlin Version: 5.5.0-1191157
ChromeDPTarget:

@Serializable
data class ChromeDPTarget(
    val id: String,
    val title: String,
    val type: String,
    val description: String,
    val devtoolsFrontendUrl: String,
    /**
     * The web socket URL to use with [HttpClient.chromeWebSocket] to connect via the debugger to this target.
     */
    val webSocketDebuggerUrl: String,
)

chrome version:
/json/version

{
   "Browser": "Chrome/85.0.4183.121",
   "Protocol-Version": "1.3",
   "User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Valve Steam Client Safari/537.36",
   "V8-Version": "8.5.210.26",
   "WebKit-Version": "537.36 (@a81aa729a8e1fd413943a339393c82e7b8055ddc)",
   "webSocketDebuggerUrl": "ws://127.0.0.1:8080/devtools/browser/f6fcbc20-51e4-4423-8596-f2edef5096b1"
}

/json

[
  {
    "description": "",
    "devtoolsFrontendUrl": "/devtools/inspector.html?ws=127.0.0.1:8080/devtools/page/F532B9DE41187A2534C7E51E3AE4B7C1",
    "id": "F532B9DE41187A2534C7E51E3AE4B7C1",
    "title": "data:text/html,<body><%2Fbody><!--tracking:7jo886:/library/downloads-->",
    "type": "page",
    "url": "data:text/html,%3Cbody%3E%3C%2Fbody%3E%3C!--tracking:7jo886:/library/downloads--%3E",
    "webSocketDebuggerUrl": "ws://127.0.0.1:8080/devtools/page/F532B9DE41187A2534C7E51E3AE4B7C1"
  }
]
@joffrey-bion joffrey-bion changed the title ChromeDPTarget don't have url property Add url property to ChromeDPTarget Oct 8, 2023
@joffrey-bion joffrey-bion added the enhancement New feature or request label Oct 8, 2023
@joffrey-bion joffrey-bion changed the title Add url property to ChromeDPTarget Add url and faviconUrl properties to ChromeDPTarget Oct 8, 2023
joffrey-bion added a commit that referenced this issue Oct 8, 2023
@joffrey-bion
Add url and faviconUrl properties to ChromeDPTarget
60c9c47 
Resolves:
#305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion