fix: error type is useApiData is a FetchError
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-api-party ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattmess1221
changed the title
|
Good catch! And great work. Thank you very much! Will review later. Just wanna send some flowers. 🌻 |
johannschopplich
requested changes
Aug 25, 2023
johannschopplich
changed the title
useApiData
mattmess1221
force-pushed
the
bugfix/async-data-error-type
branch
from
31972d0 to
e87a789
Compare
mattmess1221
force-pushed
the
bugfix/async-data-error-type
branch
from
e87a789 to
42c3a5d
Compare
mattmess1221
force-pushed
the
bugfix/async-data-error-type
branch
from
42c3a5d to
120f6a3
Compare
|
Do you think this will this still be relevant with #44? |
|
I've made changes to be more minimal. With #44, the types should be more reflective of what they are at runtime. There is an exception of course if there's a transport error in the request or some other bug causing an exception. |
mattmess1221
changed the title
useApiData useApiData is a FetchError
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The error type in useApiData is incorrect. It's actual type is a
NuxtErrorwith thedatatype dependent on whetherclient: trueis set. Ifclient: true,datais the response data from the API. Otherwise it is set to what looks like aIFetchError.📝 Checklist