Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually resolve the ref in resolvePath #40

Merged

Conversation

mattmess1221
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

ACTUALLY resolve the path parameter refs.

Turns out I missed the whole point in #39. I guess that's what I get for rushing a push on a Friday afternoon.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 28, 2023

βœ… Deploy Preview for nuxt-api-party ready!

Name Link
πŸ”¨ Latest commit 723a4f9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-api-party/deploys/64ecbacca2c9cf0008ede74a
😎 Deploy Preview https://deploy-preview-40--nuxt-api-party.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner

Shouldn't be necessary with the getter syntax:

pathParams: () => ({
  id: id.value
})

But I trust you this change is necessary in your use-case. Accepted.

@johannschopplich johannschopplich merged commit be3490b into johannschopplich:main Aug 28, 2023
@mattmess1221 mattmess1221 deleted the bugfix/pathparams-ref branch March 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants