Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom hashFn composable option #51

Closed
wants to merge 3 commits into from

Conversation

johannschopplich
Copy link
Owner

@johannschopplich johannschopplich commented Sep 14, 2023

πŸ”— Linked issue

Idea from #50

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@killjoy1221 To ease the need for your composable overwriting the hashing logic, why not add an option to the composable itself? What do you think?
You could simplify your custom composable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 14, 2023

βœ… Deploy Preview for nuxt-api-party ready!

Name Link
πŸ”¨ Latest commit 47a37ca
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-api-party/deploys/650363da10759b000899aae5
😎 Deploy Preview https://deploy-preview-51--nuxt-api-party.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattmess1221
Copy link
Contributor

What about also providing the key as a plain string the same way useAsyncData does?

useMyData("key", "path")

@johannschopplich
Copy link
Owner Author

That's probably the more native solution. πŸ˜ƒ

@johannschopplich johannschopplich deleted the feat/custom-hash-fn branch September 15, 2023 13:57
@johannschopplich johannschopplich mentioned this pull request Sep 15, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants