Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug switch sql2017 #13

Merged
merged 22 commits into from
Feb 24, 2019
Merged

Debug switch sql2017 #13

merged 22 commits into from
Feb 24, 2019

Conversation

johlju
Copy link
Owner

@johlju johlju commented Feb 23, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 23, 2019

Codecov Report

Merging #13 into switch-sql2017 will increase coverage by <1%.
The diff coverage is 98%.

Impacted file tree graph

@@              Coverage Diff               @@
##           switch-sql2017    #13    +/-   ##
==============================================
+ Coverage              97%    97%   +<1%     
==============================================
  Files                  35     35            
  Lines                4325   4372    +47     
==============================================
+ Hits                 4221   4267    +46     
- Misses                104    105     +1

@johlju johlju marked this pull request as ready for review February 24, 2019 06:50
@johlju johlju merged commit 7a28aeb into switch-sql2017 Feb 24, 2019
@johlju johlju deleted the debug-switch-sql2017 branch February 24, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants