Checkboxes #22
Merged
Checkboxes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncorrelli
requested changes
Oct 24, 2019
|
@johncorrelli addressed the review feedback in the fixup commit. |
johncorrelli
requested changes
Oct 25, 2019
bradbyte
force-pushed
the
feat/checkboxes
branch
from
c657e07 to
2f0498a
Compare
bradbyte
commented
Oct 25, 2019
bradbyte
commented
Oct 25, 2019
|
@johncorrelli do you want me to squash this all up? |
bradbyte
force-pushed
the
feat/checkboxes
branch
from
2f0498a to
19fd0ab
Compare
bradbyte
force-pushed
the
feat/checkboxes
branch
2 times, most recently
from
b8608eb to
1b2a67a
Compare
bradbyte
commented
Oct 25, 2019
bradbyte
commented
Oct 25, 2019
- React-markdown-renderer seems to have been abandoned and lacks functionality to customize individual nodes. It seems to be a pretty straight forward swap, with exception to how the syntax highlight works.
bradbyte
force-pushed
the
feat/checkboxes
branch
from
1b2a67a to
af29aa2
Compare
johncorrelli
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Thanks for your #hacktoberfest contribution @bradbumbalough - it is much appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for toggling checkboxes in real time. In order to do this, I had to swap the markdown renderer library so we could better tap into the core renderers.
Essentially, it scrubs through the note and finds checkboxes, and inserts an empty url into the label for the line index. Then, when the Checkbox component receives the children (as valid React JSX ) to render, it grabs the
hrefattribute as the "key" to use when updating the checkbox on toggle.