Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref email, some small UI fixes #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

cfsamson
Copy link

@cfsamson cfsamson commented Aug 2, 2014

Hi. Making a PR here as mentioned in the email. Now this was originally written in typescript, but I just rewrote it to fit in the form and style as the original HotTowel template. There are three small changes:

  • Menuitems now show after going from large screen to small screen, clicking a menuitem and then going back to large screen
  • When clicking on a menuitem on small screen, the menu closes after click. I used a seperate directive for this, as it is a bit tricky due to the ng-repeat. There probably is a way to do it in i.e. the sidebar directive, but I haven't figured out any other way to do it.
  • The dissolve animation now works as in the original example

It looks like there are changes to ccImgPerson but it is the same, don't know why it shows as change in the diff.

Let me know if there if you have any comments :)

Carl Fredrik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant