Fix ascii_filename
to work properly in Python 3
#76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #49. In Python 3 the result of
str.encode()
isbytes
and so"something %s" % (b'else') ==
"something b'else'", which
2to3does not catch because of the
str-
bytes` ambiguity in Python 2 (see also here). I suggest simply reconverting the ASCII-bytes into a Unicode string (containing only ASCII characters) for Python 3. Actually, the version check is redundant, as in Python 2 I thinkIs always true.
I haven't tested this code.