Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when remote follows local, hold off sending Accept if remote identity not fully fetched #676

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

alphatownsman
Copy link
Contributor

When a new remote identity follows a local identity (manual approval = false), Follow.by_ap will create a Follow and a bare bone Identity, so these will be triggered:

  • IdentityStatus.handle_outdated
  • FollowStates.handle_unrequested
  • FollowStates.handle_accepting

there are rare cases FollowStates.handle_accepting get executed before IdentityStatus.handle_outdated, which will raise exception bc missing inbox_uri

This PR should fix this.

@andrewgodwin andrewgodwin merged commit 123c20e into jointakahe:main Dec 6, 2023
3 checks passed
@andrewgodwin
Copy link
Member

Thanks!

@alphatownsman alphatownsman deleted the fix-remote-follow-local branch January 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants