when remote follows local, hold off sending Accept if remote identity not fully fetched #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new remote identity follows a local identity (manual approval = false),
Follow.by_ap
will create aFollow
and a bare boneIdentity
, so these will be triggered:IdentityStatus.handle_outdated
FollowStates.handle_unrequested
FollowStates.handle_accepting
there are rare cases
FollowStates.handle_accepting
get executed beforeIdentityStatus.handle_outdated
, which will raise exception bc missinginbox_uri
This PR should fix this.