Skip to content

Commit

Permalink
lint code
Browse files Browse the repository at this point in the history
  • Loading branch information
fcurella committed Mar 13, 2024
1 parent a934f11 commit a8e137a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 16 deletions.
13 changes: 7 additions & 6 deletions faker/providers/person/uk_UA/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from collections import OrderedDict
from typing import Dict, Optional
from ....typing import SexLiteral

from .. import Provider as PersonProvider, ElementsType
from ....typing import SexLiteral
from .. import ElementsType
from .. import Provider as PersonProvider


def translit(text: str) -> str:
Expand Down Expand Up @@ -75,7 +76,7 @@ def translit(text: str) -> str:
"Щ": "Shch",
"Ь": "",
"Ю": "Yu",
"Я": "Ya"
"Я": "Ya",
}
for letter in text:
if letter.isalpha():
Expand Down Expand Up @@ -291,7 +292,7 @@ class Provider(PersonProvider):
"Йоруба",
"Чжуан",
"Китайська",
"Зулу"
"Зулу",
]

# Source: uk.wikipedia.org/wiki/Українські_імена
Expand Down Expand Up @@ -1299,9 +1300,9 @@ def full_name(self, gender: Optional[SexLiteral] = None, short: Optional[bool] =
if gender and gender not in ("M", "F"):
raise ValueError('Gender must be "m" or "f" or None')

gender_ = gender if gender else self.random_element(elements=['M', 'F'])
gender_ = gender if gender else self.random_element(elements=["M", "F"])

if gender_ == 'M':
if gender_ == "M":
first_name = self.first_name_male()
last_name = self.last_name_male()
middle_name = self.middle_name_male()
Expand Down
22 changes: 12 additions & 10 deletions tests/providers/test_person.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import datetime
import re
import unittest

from unittest import mock

from faker import Faker
Expand Down Expand Up @@ -1503,14 +1504,15 @@ def test_language_name(self):
assert language_name in self.provider.language_names

def test_transliteration(self):
assert self.translit("Сергій") == 'Serhii'
assert self.translit("Лілія") == 'Liliia'
assert self.translit("Яся") == 'Yasia'
assert self.translit("Демʼян") == 'Demian'
assert self.translit("Марʼяна") == 'Mariana'
assert self.translit(
"абвгґдеєжзиіїйклмнопрстуфхцчшщьюяєʼ'-") == "abvhgdeiezhzyiiiklmnoprstufkhtschshshchiuiaie'-"
assert self.translit("АБВГҐДЕЄЖЗИІЇЙКЛМНОПРСТУФХЦЧШЩЬЮЯ") == 'ABVHGDEYeZhZYIYiYKLMNOPRSTUFKhTsChShShchYuYa'
assert self.translit("Сергій") == "Serhii"
assert self.translit("Лілія") == "Liliia"
assert self.translit("Яся") == "Yasia"
assert self.translit("Демʼян") == "Demian"
assert self.translit("Марʼяна") == "Mariana"
assert (
self.translit("абвгґдеєжзиіїйклмнопрстуфхцчшщьюяєʼ'-") == "abvhgdeiezhzyiiiklmnoprstufkhtschshshchiuiaie'-"
)
assert self.translit("АБВГҐДЕЄЖЗИІЇЙКЛМНОПРСТУФХЦЧШЩЬЮЯ") == "ABVHGDEYeZhZYIYiYKLMNOPRSTUFKhTsChShShchYuYa"

def test_full_name_male(self):
for _ in range(10):
Expand Down Expand Up @@ -1538,8 +1540,8 @@ def test_full_name(self):

def test_short_full_name(self):
res = self.fake.full_name(short=True)
assert res.count('.') == 2
assert res.count(' ') == 1
assert res.count(".") == 2
assert res.count(" ") == 1


if __name__ == "__main__":
Expand Down

0 comments on commit a8e137a

Please sign in to comment.