Run isort as part of CI #1097
Merged
Run isort as part of CI #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids creating a virtualenv directory inside the project directory.
|
Thank you! ✨ |
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* Run isort as part of CI isort was already configured in commit 93c9375. Now include isort in the tox matrix and run it during CI. Fix faker/factory.py to avoid the circular dependency. Fix isort early to reduce changes when dropping Python 2 support. Refs joke2k#1063 * Simplify CircleCI configuration Avoids creating a virtualenv directory inside the project directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort was already configured in commit
93c9375. Now include isort in the tox
matrix and run it during CI.
Fix faker/factory.py to avoid the circular dependency.
Fix isort early to reduce changes when dropping Python 2 support.
Refs #1063