Require cycle #183

mengerzhuanyong · 2018-09-14T06:21:52Z

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/FileReader.js -> node_modules/rn-fetch-blob/index.js

It is recommended to solve this problem！

reilem · 2018-09-17T09:06:40Z

I'm also getting these warnings on the new version of react-native.

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/Blob.js -> node_modules/rn-fetch-blob/index.js

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/XMLHttpRequest.js -> node_modules/rn-fetch-blob/index.js

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/FileReader.js -> node_modules/rn-fetch-blob/index.js

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/Fetch.js -> node_modules/rn-fetch-blob/index.js

joegoodall2 · 2018-09-25T11:21:14Z

Same issue

zhaiyjgithub · 2018-09-29T02:45:07Z

same issue

mitevdev · 2018-10-05T08:48:28Z

same issue

tenwiz · 2018-10-14T14:31:03Z

Yes, I've faced the same issue here.

tenwiz · 2018-10-14T14:31:18Z

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/Blob.js -> node_modules/rn-fetch-blob/index.js

tskorupka · 2018-10-15T13:53:46Z

Same issue :(

burtek · 2018-10-24T16:43:00Z

same here

rodrigowpl · 2018-10-26T20:39:06Z

same here, any idea?

sithartha · 2018-10-30T15:23:38Z

I've got the same.

tylerbarnett · 2018-10-31T02:20:55Z

Same Here

AsadSaleh · 2018-11-24T09:41:01Z

Any one already working on this issue? Or any one has an idea to solve this?

wd · 2018-11-26T09:18:22Z

@AsadSaleh This is not a critical problem, just a warning for 'maybe there is something wrong in your code', so you can simply ignore this warning by add codes like bellow, and wait someone will fix this warning ...

YellowBox.ignoreWarnings([
    'Remote debugger is in a background tab which may cause apps to perform slowly',
    'Require cycle: node_modules/rn-fetch-blob/index.js',
    'Require cycle: node_modules/react-native/Libraries/Network/fetch.js'
]);

qiaolin-pan · 2018-12-05T02:15:44Z

any update on this ?

soumyamishra89 · 2018-12-06T09:54:19Z

@wd This is a warning but needs to be dealt with. This has come up with new react-native version (0.57) and requires certain code restructuring in rn-fetch-blob library.

Is anyone working on this?

AGOGD · 2018-12-13T08:15:45Z

I also encountered this problem today.

zhuxianqin · 2019-01-02T10:11:54Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

nhuthuynh195 · 2019-01-02T15:15:07Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

this problem has resolved, thanks brother

Zbish · 2019-01-16T12:41:57Z

there is going to be a PR for @zhuxianqin fix ???

Faolain · 2019-01-19T21:22:12Z

@zhuxianqin can you please submit a PR with this fix?

zhuxianqin · 2019-01-31T04:36:32Z

@zhuxianqin can you please submit a PR with this fix?

sorry, I don't know how to release github project, I will try to do it in several days

zhuxianqin · 2019-02-09T09:31:01Z

@zhuxianqin can you please submit a PR with this fix?

to develop this project, I need to follow instructions below:
https://github.com/joltup/rn-fetch-blob-dev
I have to test both on android & IOS
Sorry, I think it's better for the original owner to fix it

msqar · 2019-02-10T00:54:35Z

@zhuxianqin seems that they are not adding it, it sucks man :(

Seems that you know this library a lot, though. Can you help me with something? I created this post
#305

ThaJay · 2019-02-20T17:28:56Z

This should be fixed. I'm glad react-native now warns about this but there should have never been cyclic dependencies in the first place.

here it is solved with constructor injection:
https://stackoverflow.com/questions/38841469/how-to-fix-this-es6-module-circular-dependency/44226565#44226565

software-mansion/react-native-svg#773

Another way to solve this is to make an interface with a setter and a getter and require the interface instead of the original class. The original file uses the setter and all others use the getter.

interface.js:

let thing = {}

export function getThing () {
  return thing
}

export function setThing (thingToSet) {
  thing = thingToSet
}

thing.js:

import {setThing} from './interface'

class Thing {}

setThing(Thing)

other files:

import {getThing} from './interface'

const Thing = getThing()

msqar · 2019-02-20T17:44:38Z

@ThaJay yea man, i receive like 6-7 warning notifications every time i refresh the app, is getting super annoying.
Do you have any idea how to apply this interface for this specific case?

vitorverasm · 2019-02-20T21:20:10Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

This did the trick on RN 0.57
This bug should be fixed...

msqar · 2019-02-21T00:48:33Z

@vitor-veras i have to put the fetch-blob file in my app and edit it then? no other way until they fix this? :/ i don't get it, i assume i don't have to update these files directly from node_modules otherwise it will be over-written whenever i do another npm install... so how should i do it?

vitorverasm · 2019-02-21T02:07:09Z

That's only a warning from React Native, but it can slowdown the app performance. And yes if you update the package with npm/yarn the fix will go away. There's no proper aproach to this i think, hopefully the dev team fix this soon. There is actually a PR for this #296 .

Faolain · 2019-03-09T22:30:59Z

As mentioned by @alpha0010 in #296 one would encounter problems where RNFetchBlob is called within the files the import is removed from.

@ThaJay would you be able to submit a PR?

Removed all the requiring cycles by changing all to use directly the NativeModules

MSH786 · 2021-04-14T21:05:42Z

import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

This also works in react-native-fetch-blob

Thanks Dude!

ujangmisbah · 2021-05-10T07:25:36Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

Thanks, this works fine

storkyle · 2021-06-23T15:30:33Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

Thanks brother, @zhuxianqin !

Note: I made a patch from @zhuxianqin's solution. I hope that makes it easier 😃

install patch-package
create a folder in your project called "patches"
Inside "patches" folder get the patch from this gist (for convenience) https://gist.github.com/storkyle/d2f09ef376b3843915345150b0740977 . And name it as rn-fetch-blob+0.12.0.patch
add "patch-package" in postinstall in package.json before doing yarn install.
In package.json

"scripts": {
    "postinstall": "patch-package"
 }

run yarn install or npm install

Remigius2011 · 2021-06-28T12:57:19Z

@storkyle , thanks for the patch. this works for me.

Question: does anybody know of a maintained fork or a good replacement for rn-fetch-blob?

cristianoccazinsp · 2021-06-28T13:01:16Z

https://github.com/RonRadtke/react-native-blob-util

alpha0010 · 2021-06-29T13:17:00Z

Self promotion: I wrote https://github.com/alpha0010/react-native-file-access when this library was marked as unmaintained. API is similar, but implementation is completely new. Feature set reduced to what I thought were the essentials (less code/simpler code means fewer places for bugs... in theory).

dexiouz · 2021-07-08T15:45:54Z

Modify these files can avoid require cycle:
IN DIR rn-fetch-blob/polyfill
all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js'
import {NativeModules} from 'react-native';
const RNFetchBlob = NativeModules.RNFetchBlob

Awesome. This fixed the issue for me

keisan1231 · 2021-08-09T06:13:39Z

I resolved this script

Please write in ${root}/script/rn-fetch-blob_warning.js

var fs = require('fs');

const replaced = `import RNFetchBlob from '../index.js'`;
const replacement = `import {NativeModules} from 'react-native';\nconst RNFetchBlob = NativeModules.RNFetchBlob`;

const files = [
  'node_modules/rn-fetch-blob/polyfill/Fetch.js',
  'node_modules/rn-fetch-blob/polyfill/Blob.js',
  'node_modules/rn-fetch-blob/polyfill/XMLHttpRequest.js',
];

files.forEach(file => {
  fs.readFile(file, 'utf8', function (err, data) {
    if (err) {
      return console.log(err);
    }

    var result = data.replace(new RegExp(replaced, 'g'), replacement);
    fs.writeFile(file, result, 'utf8', function (err) {
      if (err) return console.log(err);
    });
  });
});

and in package.json

"scripts": {
.....
    "postinstall": "node scripts/rn-fetch-blob_warning.js"
  },

Please reinstall. (yarn install)
Then , waring vanishes

gtaylor44 · 2021-08-12T05:28:03Z

Thank you @storkyle ... Don't need to manually patch each time packages are installed with this solution.

rn-fetch-blob is no longer maintained and a [require cycle issue](joltup/rn-fetch-blob#183) constantly shows warnings in the latest version of RN when we start the app. This updates the package to use [react-native-blob-util](https://github.com/RonRadtke/react-native-blob-util) instead which is a maintained fork of the original package.

Fix for #183

Faseeh-Abbas-Khan · 2022-03-09T18:47:04Z

Modify these files can avoid require cycle: IN DIR rn-fetch-blob/polyfill all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js' import {NativeModules} from 'react-native'; const RNFetchBlob = NativeModules.RNFetchBlob

Worked for me

satyabrata45 · 2022-03-30T10:27:40Z

Same issue

rk-maker · 2022-03-31T06:00:14Z

Modify these files can avoid require cycle: IN DIR rn-fetch-blob/polyfill all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js' import {NativeModules} from 'react-native'; const RNFetchBlob = NativeModules.RNFetchBlob

Thanks man this issue has been resolved

biplovappservinc · 2022-05-05T05:06:26Z

this is all are fixing not a permanent solution.

technokasim · 2022-05-27T14:31:42Z

Modify these files can avoid require cycle: IN DIR rn-fetch-blob/polyfill all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js' import {NativeModules} from 'react-native'; const RNFetchBlob = NativeModules.RNFetchBlob

It works for me. thanks

pond · 2022-06-19T21:19:18Z

Cyclic dependencies for almost 4 years and still not fixed?

That's... Unfortunate :-O

tarouboy · 2022-06-21T01:29:41Z

Try this forked package, still actively maintained.
https://github.com/RonRadtke/react-native-blob-util

lfrallon · 2022-10-01T15:20:22Z

Hello, this still exists on:

"react": "18.0.0",
"react-native": "^0.69.0",
"rn-fetch-blob": "^0.12.0",

Update:

Fix after I installed "rn-fetch-blob": "0.13.0-beta.2" mentioned in #798 (comment).

mickey35vn · 2023-04-14T05:06:32Z

Modify these files can avoid require cycle: IN DIR rn-fetch-blob/polyfill all thease 4 files: Blob.js, Fetch.js, FileReader.js, XMLHttpRequest.js

// import RNFetchBlob from '../index.js' import {NativeModules} from 'react-native'; const RNFetchBlob = NativeModules.RNFetchBlob

it works for me, many thanks

* master: Add timeout for ressource Fix issue : joltup#183 (comment) some fixes fix downloaded pdf # Conflicts: # android/src/main/java/com/ReactNativeBlobUtil/Utils/PathResolver.java # polyfill/Blob.js # polyfill/Fetch.js # polyfill/XMLHttpRequest.js

Adil7767 · 2023-08-21T14:11:50Z

Require cycle: node_modules/rn-fetch-blob/index.js -> node_modules/rn-fetch-blob/polyfill/index.js -> node_modules/rn-fetch-blob/polyfill/Fetch.js -> node_modules/rn-fetch-blob/index.js Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
same issue is here

t3chnoboy mentioned this issue Oct 13, 2018

Warning Require cycle after installing #203

Open

DarkLink363 added a commit to DarkLink363/rn-fetch-blob that referenced this issue Apr 12, 2021

Fix for joltup#183 joltup#688

5923284

Removed all the requiring cycles by changing all to use directly the NativeModules

yfng96 mentioned this issue Aug 5, 2021

Require cycle: node_modules/react-native-blob-util/index.js RonRadtke/react-native-blob-util#58

Closed

joblesspoet added a commit to joblesspoet/react-native-fetch-blob that referenced this issue Dec 25, 2021

fixed issues according to joltup#183 (comment)

f2471bc

vbejgrowicz mentioned this issue Feb 11, 2022

Resolve require cycle issue from rn-fetch-blob DogParkLabs/react-native-activestorage#2

Merged

rpenfold added a commit that referenced this issue Feb 23, 2022

Merge pull request #688 from alexnaiman/fix_183_requiring_cycles

cc54ea9

Fix for #183

GregoireDucharme mentioned this issue Mar 10, 2022

Require cycle #768

Open

phoenix377 mentioned this issue Apr 12, 2022

Address this warning phoenix377/react-native-sample#1

Open

1 task

lfrallon mentioned this issue Dec 6, 2022

Failed to build in RN ^0.69.0 nodece/react-native-apk-installer-n#9

Closed

Require cycle #183

Require cycle #183

Comments

mengerzhuanyong commented Sep 14, 2018

reilem commented Sep 17, 2018 • edited Loading

joegoodall2 commented Sep 25, 2018 • edited Loading

zhaiyjgithub commented Sep 29, 2018

mitevdev commented Oct 5, 2018

tenwiz commented Oct 14, 2018

tenwiz commented Oct 14, 2018

tskorupka commented Oct 15, 2018

burtek commented Oct 24, 2018

rodrigowpl commented Oct 26, 2018

sithartha commented Oct 30, 2018

tylerbarnett commented Oct 31, 2018

AsadSaleh commented Nov 24, 2018

wd commented Nov 26, 2018 • edited Loading

qiaolin-pan commented Dec 5, 2018

soumyamishra89 commented Dec 6, 2018

AGOGD commented Dec 13, 2018

zhuxianqin commented Jan 2, 2019

nhuthuynh195 commented Jan 2, 2019 • edited Loading

Zbish commented Jan 16, 2019

Faolain commented Jan 19, 2019

zhuxianqin commented Jan 31, 2019

zhuxianqin commented Feb 9, 2019

msqar commented Feb 10, 2019 • edited Loading

ThaJay commented Feb 20, 2019 • edited Loading

msqar commented Feb 20, 2019

vitorverasm commented Feb 20, 2019 • edited Loading

msqar commented Feb 21, 2019 • edited Loading

vitorverasm commented Feb 21, 2019 • edited Loading

Faolain commented Mar 9, 2019

MSH786 commented Apr 14, 2021

ujangmisbah commented May 10, 2021

storkyle commented Jun 23, 2021 • edited Loading

Thanks brother, @zhuxianqin !

Remigius2011 commented Jun 28, 2021

cristianoccazinsp commented Jun 28, 2021

alpha0010 commented Jun 29, 2021

dexiouz commented Jul 8, 2021

keisan1231 commented Aug 9, 2021

I resolved this script

gtaylor44 commented Aug 12, 2021

Faseeh-Abbas-Khan commented Mar 9, 2022

satyabrata45 commented Mar 30, 2022

rk-maker commented Mar 31, 2022

biplovappservinc commented May 5, 2022

technokasim commented May 27, 2022

pond commented Jun 19, 2022

tarouboy commented Jun 21, 2022

lfrallon commented Oct 1, 2022 • edited Loading

mickey35vn commented Apr 14, 2023

Adil7767 commented Aug 21, 2023

reilem commented Sep 17, 2018 •

edited

Loading

joegoodall2 commented Sep 25, 2018 •

edited

Loading

wd commented Nov 26, 2018 •

edited

Loading

nhuthuynh195 commented Jan 2, 2019 •

edited

Loading

msqar commented Feb 10, 2019 •

edited

Loading

ThaJay commented Feb 20, 2019 •

edited

Loading

vitorverasm commented Feb 20, 2019 •

edited

Loading

msqar commented Feb 21, 2019 •

edited

Loading

vitorverasm commented Feb 21, 2019 •

edited

Loading

storkyle commented Jun 23, 2021 •

edited

Loading

lfrallon commented Oct 1, 2022 •

edited

Loading