Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh mode not working #430

Closed
HageMaster3108 opened this issue Aug 18, 2015 · 16 comments
Closed

Refresh mode not working #430

HageMaster3108 opened this issue Aug 18, 2015 · 16 comments
Labels

Comments

@HageMaster3108
Copy link

Hi,

refresh mode is not working at all right now - using tig 2.0.3 on os x (retrieved via brew).
My .tigrc looks like this:

set refresh-mode = periodic
set refresh-interval = 5

Also tried the "auto" mode.

Tickets #389 and #301 seem to indicate that it is related to large repos? I can't confirm that. I have just setup a clean empty repo with just a single text file and can't get it to work.

Cheers,
Patrick

@geakstr
Copy link

geakstr commented Sep 7, 2015

Same for me. OS X 10.10.5, git 2.3.2, tig 2.1.1.

@jonas
Copy link
Owner

jonas commented Sep 13, 2015

Yes, this is definitely broken.

@lehnerpat
Copy link

@jonas, is there any way we can provide useful debugging info for this issue?

The auto-refresh would be the "killer feature", as it were, to make me use tig. I'm guessing true "auto" refresh is currently difficult without something like inotify -- periodic refresh would work well enough for me though.

I'm currently on OS X 10.11 with tig-2.1.1 (built Sep 13 2015) (installed via homebrew).

@napcae
Copy link

napcae commented Nov 4, 2015

Can confirm, does not work. If I can provide any information, please tell me how.

$ brew info tig
tig: stable 2.1.1 (bottled), HEAD
Text interface for Git repositories
http://jonas.nitro.dk/tig/
/usr/local/Cellar/tig/2.1.1 (8 files, 428K) *
  Poured from bottle
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/tig.rb
==> Dependencies
Recommended: readline ✔
==> Options
--with-docs
        Build man pages using asciidoc and xmlto
--without-readline
        Build without readline support
--HEAD
        Install HEAD version
==> Caveats
Bash completion has been installed to:
  /usr/local/etc/bash_completion.d

SystemInformation:

$ archey

                 ###                  User: napcae
               ####                   Hostname: butterfinger
               ###                    Distro: OS X 10.11.1
       #######    #######             Kernel: Darwin
     ######################           Uptime: 11:09  up 5 days,  8:41, 1 user, load averages: 2,19 2,16 2,18
    #####################             Shell: /bin/bash
    ####################              Terminal: screen-256color iTerm.app
    ####################              Packages: 149
    #####################             CPU: Intel Core i5-4258U CPU @ 2.40GHz
     ######################           Memory: 8 GB
      ####################            Disk: 95%
        ################              Battery: 54,27%
         ####     #####               

tigrc:

$ less ~/.tigrc
      1 set refresh-mode = auto
/Users/napcae/.tigrc (END)

@sevagh
Copy link

sevagh commented Dec 27, 2015

Is this only an OSX problem? Refresh doesn't seem to be working for me on Linux (Fedora).

@geakstr
Copy link

geakstr commented Dec 27, 2015

@jonas, can you indicate where this functionality implemented in sources? I can try to research this problem.

@jonas jonas added the component:refresh-mode Refresh mode label Jan 5, 2016
@vaygr
Copy link

vaygr commented Mar 31, 2017

Can confirm that's still valid for 2.2.1 on Linux.

@jonas
Copy link
Owner

jonas commented Apr 1, 2017

Yes, didn't get around to looking at this issue yet.

@sevagh
Copy link

sevagh commented Apr 5, 2017

If you could give me a clue on where to start looking in the source code, I'd like to attempt a fix.

@jonas
Copy link
Owner

jonas commented Apr 6, 2017

@sevagh That would be great. The main logic is inside src/watch.c

@mnarrell
Copy link

Any update here?

@spytheman
Copy link
Contributor

I've just made a pull request for this issue: #591 .

@jonas jonas closed this as completed in f4fbccc Apr 29, 2017
ifyouseewendy added a commit to ifyouseewendy/dotfiles that referenced this issue Apr 29, 2017
@frontsideair
Copy link

Can we get a release too? ☺️

@jonas
Copy link
Owner

jonas commented May 6, 2017

@frontsideair The fix has been release in https://github.com/jonas/tig/releases/tag/tig-2.2.2

@timotheecour
Copy link

timotheecour commented Mar 7, 2018

/cc @jonas @HageMaster3108

could we reopen?

this doesn't work reliably at all. It seems to work for the 1st 2 or so edits, then doesn't refresh when a file is updated again.

tig --version
tig version 2.3.3

Distro: OS X 10.13.3

I tried both:
set refresh-mode = auto
and
set refresh-mode = periodic
set refresh-interval = 5

maybe it's a dup of #389 ? in any case, seems broken

NOTE that F5 works

@jonas
Copy link
Owner

jonas commented Mar 15, 2018

@timotheecour Please create a new issue.

koutcher added a commit that referenced this issue Mar 2, 2020
The extra load_refs() introduced by #591 to fix #430 is no longer needed
after #917 and causes the loop.

Fixes #991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests