Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tig jumps to a match after canceling search #627

Closed
0ax1 opened this issue Jun 29, 2017 · 0 comments
Closed

tig jumps to a match after canceling search #627

0ax1 opened this issue Jun 29, 2017 · 0 comments
Milestone
tig-2.3.0

Comments

@0ax1
Copy link

0ax1 commented Jun 29, 2017

How to reproduce:

  • Search for sth. that has a match and press enter
  • Start another search with '/' and cancel the search with C-C
  • Instead of doing nothing, tig jumps to an instance of the previous match
rolandwalker added a commit to rolandwalker/tig that referenced this issue Jul 7, 2017
@rolandwalker
distinguish cancel and empty string at all prompts
31e1c3a 
Fixes jonas#627

* maintain the distinction between null pointers and strings of length
  zero, representing canceled input and empty input, respectively
* at the input boundary, capture the distinction by setting a flag in the
  readline signal handler
* when configured --without-readline change the way read_prompt() calls
  read_prompt_incremental() to avoid regressions
@rolandwalker rolandwalker mentioned this issue Jul 7, 2017
Merged
rolandwalker added a commit to rolandwalker/tig that referenced this issue Jul 7, 2017
@rolandwalker
distinguish cancel and empty string at all prompts
ce36db3 
Fixes jonas#627

* maintain the distinction between null pointers and strings of length
  zero, representing canceled input and empty input, respectively
* at the input boundary, capture the distinction by setting a flag in the
  readline signal handler
* when configured --without-readline change the way read_prompt() calls
  read_prompt_incremental() to avoid regressions
rolandwalker added a commit to rolandwalker/tig that referenced this issue Jul 7, 2017
@rolandwalker
distinguish cancel and empty string at all prompts
a2f8479 
Fixes jonas#627

* maintain the distinction between null pointers and strings of length
  zero, representing canceled input and empty input, respectively
* at the input boundary, capture the distinction by setting a flag in the
  readline signal handler
* when configured --without-readline change the way read_prompt() calls
  read_prompt_incremental() to avoid regressions
@jonas jonas closed this as completed in #652 Jul 9, 2017
jonas pushed a commit that referenced this issue Jul 9, 2017
@rolandwalker @jonas
distinguish cancel and empty string at all prompts
c2e2a0f 
Fixes #627

* maintain the distinction between null pointers and strings of length
  zero, representing canceled input and empty input, respectively
* at the input boundary, capture the distinction by setting a flag in the
  readline signal handler
* when configured --without-readline change the way read_prompt() calls
  read_prompt_incremental() to avoid regressions
@jonas jonas modified the milestone: tig-2.3 Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
tig-2.3.0
Development

No branches or pull requests
2 participants
@jonas @0ax1