cleanups and tests on view format widths #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
changed the title
width on status is documented, accepted, but ignored; remove it width on text is undocumented, accepted, but ignored; remove it width on commit-title is undocumented, accepted, but ignored; remove it fix: width of 1 fails when column is trimmed add tests for all remaining columns that support width adjust main/view-split-test to match - neither behavior is correct
rolandwalker
force-pushed
the
width-cleanups-tests
branch
from
5ffa68a to
795322e
Compare
rolandwalker
changed the title
|
At one point I had a prototype to make "fields" right adjustable to mimic the layout of Thanks for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthonline-numberis documented, accepted, but ignored; make it workwidthonstatusis documented, accepted, but ignored; remove itwidthontextis undocumented, accepted, but ignored; remove itwidthoncommit-titleis undocumented, accepted, but ignored; remove itwidth=1fails when column is trimmedwidthmain/view-split-testto match this logicI simply removed status/text/commit-title because the intent of the design seems to be that these be rightmost and right-filling. Though it is certainly a reasonable feature to want.
Edit:
view-split-testwas adjusted to fit this, though neither behavior is correct. The UTF-8 logic should be capable of truncating to two visible cells作者.