bindable control characters Ctrl-C, Ctrl-V, Ctrl-S, Ctrl-@, hardcode readline Ctrl-C #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
more-control-character-bindings
branch
from
1a9d547 to
da99e4a
Compare
* Ctrl-C/V/S would previously have been bindable in the main UI only if the user did some unusual things with stty before execution * raw() mode requires a special case to preserve Ctrl-Z behavior * C-@ (NUL) is a valid key, and useful as a translation of Ctrl-<Space> * bindings at the readline prompt are affected by this in that eg Ctrl-S becomes available, but the user still must configure those keys separately in ~/.inputrc: doc that * Ctrl-C at the readline prompt is a special case and cannot be bound; however we can absorb the SIGINT to get intuitive "abort input" behavior * bind Ctrl-C to quit by default
rolandwalker
force-pushed
the
more-control-character-bindings
branch
from
da99e4a to
167d59e
Compare
jonas
reviewed
Jun 28, 2017
| @@ -545,6 +545,9 @@ the keybindings for the *generic* keymap, and last the default keybindings. | |||
| Thus, the view keybindings override the generic keybindings which override the | |||
| built-in keybindings. | |||
|
|
|||
| Keybindings at the line-entry prompt are typically governed by the readline | |||
| library, and are configured separately in `~/.inputrc`. See 'readline(1)'. | |||
|
Thank you for the detailed commit message. My personal setup and usage of the terminal is too basic to ever have noticed these limitations. It makes sense to use |
This was referenced Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sttybefore executingtigraw()mode requires a special case to preserve prior Ctrl-Z behavior~/.inputrc: doc that~/.inputrc; however we can absorb theSIGINTto get intuitive "abort input" behavior.quitby default in the main UI, to emulate previous behaviorThe Ctrl-C in readline behavior has a more natural look after #618.
Fixes #583