Persistent readline history #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeees, looking forward to using this. \o/ |
jonas
reviewed
Jun 28, 2017
include/tig/prompt.h
Outdated
| @@ -46,6 +46,8 @@ struct input { | |||
| enum input_status prompt_default_handler(struct input *input, struct key *key); | |||
| char *read_prompt_incremental(const char *prompt, bool edit_mode, bool allow_empty, input_handler handler, void *data); | |||
| char *read_prompt(const char *prompt); | |||
| const char *prompt_histfile(void); | |||
| void prompt_teardown(void); | |||
There was a problem hiding this comment.
One minor nit, these don't have to be exported.
jonas
reviewed
Jun 28, 2017
src/prompt.c
Outdated
| @@ -466,10 +467,44 @@ read_prompt(const char *prompt) | |||
| return line; | |||
| } | |||
|
|
|||
| const char * | |||
There was a problem hiding this comment.
... and both can be declared static.
|
Very nice. |
rolandwalker
force-pushed
the
readline-persistent-history-file
branch
from
b180466 to
c29f5da
Compare
jonas
reviewed
Jun 28, 2017
src/prompt.c
Outdated
| prompt_teardown(void) | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
Forgot to mention that these can be removed. But I can do that after merge.
or $XDG_DATA_HOME/tig/history
rolandwalker
force-pushed
the
readline-persistent-history-file
branch
from
c29f5da to
54ce4e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist readline history to
~/.tig_historyor$XDG_DATA_HOME/tig/history.Arguably the
$XDG_DATA_HOMEpart doesn't belong inprompt.cbut this does keep#ifdef HAVE_READLINEtucked into a single file.It might be preferable to persist only the "search" part of the history as
lessdoes. Certainly that's the part of the feature I intend to use. However, all readline inputs are currently merged in the volatile history, and I wanted to avoid changing existing UI.Another desirable refinement would be to take
HISTORY_SIZEfrom a~/.tigrcoption, and support disabling persistent history when set to zero.It doesn't seem practical to provide test coverage as there isn't a reliable way to inspect the binary for its compile-time readline configuration.