Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix back/parent in tree-view: single pop and return #641

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

rolandwalker
Copy link
Contributor

Immediately return REQ_NONE after pop on back/parent action in tree-view. Otherwise back/parent will always perform two actions.

It looks like continuing on to switch (line->type) was the correct behavior prior to f893b0a.

@jonas
Copy link
Owner

jonas commented Jul 4, 2017

This indeed looks like a regression. Thanks for adding a test.

@jonas jonas merged commit 44df9f9 into jonas:master Jul 4, 2017
@rolandwalker rolandwalker deleted the tree-fake-cd-return branch July 4, 2017 01:43
@jonas jonas modified the milestone: tig-2.3 Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants