configurable truncation-delimiter w/ utf8 suggestion/special value #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
configurable-truncation-delimiter
branch
from
fad50fb to
15a17f7
Compare
|
We can change the wording if you prefer. Do you prefer "ellipsis"? |
|
"Ellipsis" over "truncation"? Both read fine. "Delimiter" is confusing compared to other choices such as "character", "symbol", "glyph", "marker", etc. I suppose that's because delimiters show (or define) boundaries, and this mechanism is about hiding. Just a point of English and not a big deal! |
|
Yeah, not being a native English speaker and not being much of a speaker at all makes for some confusing choice of words. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Midline Horizontal Ellipsischaracter is exactly for this purpose. No change to defaults, but the value becomes configurable.I find the term "delimiter" confusing in this context, but followed the existing wording.