Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Ctrl-C to terminate file-finder prompt #648

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

rolandwalker
Copy link
Contributor

This is a special case with its own input handler. It's also a little annoying that C-C appears in the help screen for some cases and not for others.

Incidentally it is difficult to figure out that the search keymap applies to the file-finder rather than the / search.

@rolandwalker rolandwalker force-pushed the ctrl-c-terminate-finder branch from c534d7a to 2c6c34e Compare July 6, 2017 18:03
@jonas
Copy link
Owner

jonas commented Jul 6, 2017

The search keymap should probably be renamed to edit? I initially introduced it when working on incremental search (#5) and decided to use it for the file finder. An edit keymap makes more sense if we want to repurpose it for things like the y/n prompt etc.

Copy link
Owner

@jonas jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@jonas jonas merged commit 809a2af into jonas:master Jul 6, 2017
@rolandwalker rolandwalker deleted the ctrl-c-terminate-finder branch July 6, 2017 20:14
@rolandwalker
Copy link
Contributor Author

I can't think of a single keymap name that would sensibly cover both y/n prompts and file-search.

incremental or filter might be a decent name for what search does now, with some room for the feature to grow into other areas like filtering views by refname.

@jonas
Copy link
Owner

jonas commented Jul 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants