Use a faster search when checking for item in SortedList (dotnet#12041)

jonathanpeppers · Dec 13, 2022 · 3cf3624 · 3cf3624
1 parent 149c20d
commit 3cf3624
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/src/TestUtils/src/DeviceTests.Runners/VisualRunner/Utils/SortedList.cs b/src/TestUtils/src/DeviceTests.Runners/VisualRunner/Utils/SortedList.cs
@@ -18,21 +18,10 @@ public SortedList(IComparer<T> comparer)
 
 		public int IndexOf(T item)
 		{
-			// PERF hint: this is a O(n) algorithm but could be rewritten as a O(log n) one.
 			if (Count == 0)
 				return ~0;
 
-			for (var i = 0; i < Count; i++)
-			{
-				var existing = this[i];
-				var compare = _comparer.Compare(item, existing);
-				if (compare == 0)
-					return i;
-				if (compare < 0)
-					return ~i;
-			}
-
-			return ~Count;
+			return _list.BinarySearch(item, _comparer);
 		}
 
 		public void Insert(int index, T item)