Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1234

Merged
merged 7 commits into from
Sep 1, 2019
Merged

Fix warnings #1234

merged 7 commits into from
Sep 1, 2019

Conversation

Allofich
Copy link
Contributor

@Allofich Allofich commented Sep 1, 2019

  1. There were some value conversion warnings that appeared in the Visual Studio 2017 builds recently, fixed so there are 0 warnings again.

  2. Fixed various GCC warnings. Building with GCC 9 I see no GCC code warnings now with the code itself. There is still this:

dosbox.cpp:968:6: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  968 | void DOSBOX_SetupConfigSections(void) {

and various warnings about unrecognized warning flags, issues in the configure file, etc., but no more warnings for the code itself.

  1. Fixes one non-code warning, about renaming configure.in to configure.ac.

Compiles and runs.

@Allofich
Copy link
Contributor Author

Allofich commented Sep 1, 2019

There were 3 code warnings when running with Clang 8. Fixed 2 of them.

The remaining one is already commented in the code, wasn't sure what to do about it.

gui_tk.cpp:149:45: warning: result of comparison of constant 91 with expression
      of type 'GUI::Font::SpecialChar' is always true
      [-Wtautological-constant-out-of-range-compare]
  ...if (font->toSpecial(text[seqstart++]) != '[') break; /* FIXME: Clang/LLV...
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~

@joncampbell123 joncampbell123 merged commit 330bc6c into joncampbell123:master Sep 1, 2019
@FredBezies FredBezies mentioned this pull request Sep 30, 2023
This was referenced Nov 20, 2023
@FredBezies FredBezies mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants