Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABNT C2 support and Mac F16-19 key support (SDL1) #4163

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

maron2000
Copy link
Contributor

This PR adds support for the following keys.

Keypad comma/ABNT C2(.) (Windows/Mac)
Keypad equals (Windows)
'Section' key ('@' key for French AZERTY) (Mac)
F17, F18, F19 keys (Mac: no keys assigned as default so you can assign one you desire)
JP Ro/ABNT C1, JP yen (Mac: Change to be as same as Windows)
JP Eisu and JP Kana (Mac: no keys assigned as default so you can assign one you desire)

@joncampbell123
Copy link
Owner

I'm concerned whether this breaks PC-98 emulation or Japanese keyboard support in any way. Can someone test this code to verify?

@maron2000
Copy link
Contributor Author

Thanks for your comment.
I tested the Windows version with and without PC-9801 emulation, and both keypad comma and equals are not broken.
(Since there are no such keys on my JP106 keyboard, I mapped unused keys to confirm)
Also, JP ro, JP yen , JP Eisu, and JP Kana on Mac worked as expected.

@joncampbell123
Copy link
Owner

Sounds good.

@joncampbell123 joncampbell123 merged commit 9cafe87 into joncampbell123:master Apr 14, 2023
@maron2000 maron2000 deleted the keyfix branch May 29, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants