Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitch of DBCS character at the end of a line #5528

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

maron2000
Copy link
Contributor

When printing out messages in translation files, the current code is supposed to set the first byte of a DBCS character not to be located at the end of line, but by default the feature is disabled.
This PR fixes so that the feature is enabled by default.

image

@joncampbell123 joncampbell123 merged commit 4f56057 into joncampbell123:master Mar 1, 2025
21 of 22 checks passed
@maron2000 maron2000 deleted the fix_DBCSline_end branch March 4, 2025 23:23
@1abcd
Copy link
Contributor

1abcd commented Mar 6, 2025

Hi @maron2000

I found a similar problem when I typed or pasted these texts.

a十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅
a十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅十卅
a〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺〸〺

@maron2000
Copy link
Contributor Author

Thank you and yes, I was aware of that as well, but haven't figured out how to fix it.

@1abcd
Copy link
Contributor

1abcd commented Mar 6, 2025

未命名

https://github.com/joncampbell123/dosbox-x/commits/master/?since=2021-12-11&until=2021-12-12&author=Wengier
There are some changes that are relative to the DBCS problem.
But I can not understand that. That might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants