Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible wrong log level in reload_config! #400

Closed
melvinsh opened this issue Jul 25, 2019 · 3 comments
Closed

Possible wrong log level in reload_config! #400

melvinsh opened this issue Jul 25, 2019 · 3 comments

Comments

@melvinsh
Copy link

Every time I start my environment with log level WARN I get the following message from all of my workers:

WARN: Loading runner configuration...

This seems to be defined here:

sneakers/lib/sneakers/runner.rb

Line 43 in 7c059d1

Sneakers.logger.warn("Loading runner configuration...")

Shouldn't this be Sneakers.logger.info as it is not an actionable warning?
@melvinsh
Copy link
Author

melvinsh commented Aug 4, 2019

@gabrieljoelc what do you think? I'd be happy to submit a PR.

@gabrieljoelc
Copy link
Collaborator

yes it should and yes please do! 🙏

@melvinsh
Copy link
Author

Thanks @gabrieljoelc & @michaelklishin 😊👏

hedacharon pushed a commit to kontentcore/sneakers that referenced this issue Apr 21, 2021
@michaelklishin
Closes jondot#400
743e6c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrieljoelc @melvinsh