Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add update to clientbuilder doc #280

Merged
merged 4 commits into from
Dec 15, 2024
Merged

chore: add update to clientbuilder doc #280

merged 4 commits into from
Dec 15, 2024

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Nov 19, 2024

jonhoo
jonhoo reviewed Nov 25, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@hhamud hhamud requested a review from jonhoo November 25, 2024 21:17
jonhoo
jonhoo approved these changes Dec 15, 2024
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jonhoo jonhoo merged commit c8c7f38 into jonhoo:main Dec 15, 2024
16 of 17 checks passed
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.94%. Comparing base (1085553) to head (cdbe647).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/lib.rs 96.15% <ø> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation update
2 participants
@hhamud @jonhoo