Added Serde support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
jonhoo
requested changes
Mar 11, 2022
jonhoo
requested changes
Mar 12, 2022
jonhoo
requested changes
Mar 19, 2022
src/serde.rs
Outdated
| let mut bag = serializer.serialize_seq(Some(self.len()))?; | ||
|
|
||
| for (entry, count) in self.set_iter() { | ||
| bag.serialize_element(&(&entry, &count))?; |
There was a problem hiding this comment.
Suggested change
| bag.serialize_element(&(&entry, &count))?; | |
| bag.serialize_element(&(entry, &count))?; |
entry is already a &T — no need to take a further reference.
jonhoo
requested changes
Mar 20, 2022
src/lib.rs
Outdated
| @@ -12,6 +12,10 @@ | |||
| //! If you want to use a hash table with [amortized resizes](https://github.com/jonhoo/griddle/), | |||
| //! set the `amortize` feature. | |||
| //! | |||
| //! (De)serialization via serde is also available with the `serde` feature. | |||
| //! Serialization note: if the incoming data has repeated keys, the resulting `HashBag` will merge | |||
There was a problem hiding this comment.
Would you mind adding a test for this behavior too?
There was a problem hiding this comment.
I added two tests to mirror the other tests. I also corrected my wording here. We are not concerned about communicating how we serialize a HashBag, only how we deserialize one.
jonhoo
reviewed
Mar 20, 2022
| #[test] | ||
| fn repeat_simple_entries() { | ||
| let jsonified_vikings: String = | ||
| "[[\"Einar\",1],[\"Olaf\",1],[\"Olaf\",1],[\"Harald\",2],[\"Harald\",1]]".to_string(); |
There was a problem hiding this comment.
Just a tip: you can use raw string literals to avoid all the \" in there :)
|
Published in 0.1.5 🎉 |
jonhoo
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds serialization and deserialization support via serde. This is done through an intermediate type that wraps each instance of
Twith its count.