New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add Guid type hiding raw ibv GUID #16

Merged

jonhoo merged 3 commits into jonhoo:master from planetA:mplaneta/guid-type

Nov 10, 2021

Contributor

planetA commented Aug 22, 2021

Create new Guid type that takes care of endianness conversion.

planetA mentioned this pull request

[RFC] GUID byte-order #15

Open

Owner

jonhoo commented Aug 26, 2021

Ah, I see what you're going for, but I think I wouldn't try a solution quite this drastic. It's fine to leave the __be64 type in bindgen — we don't generally expect people to be reaching into the ffi module. Then the error you were running into should also go away. I've also left a couple of notes inline.

jonhoo reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

jonhoo reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

jonhoo reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

jonhoo reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

jonhoo reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

planetA force-pushed the mplaneta/guid-type branch from 2bf1e1a to 25aeb5e Compare

September 19, 2021 18:12

jonhoo requested changes

View reviewed changes

Owner

jonhoo left a comment

Looking better! I left a few more inline comments.

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

planetA force-pushed the mplaneta/guid-type branch from 25aeb5e to 9e4c338 Compare

October 19, 2021 18:52

jonhoo approved these changes

View reviewed changes

Owner

jonhoo left a comment

This looks good, just one more nit!

src/lib.rs Outdated

-                      if guid == 0 {
+                  pub fn guid(&self) -> io::Result<Guid> {
+                      let guid_int = unsafe { ffi::ibv_get_device_guid(*self.0) };
+                      let guid : Guid = guid_int.into();

Owner

jonhoo Oct 24, 2021

I think rustfmt probably doesn't agree with the formatting here. Could you run rustfmt on the code and then update the PR?

planetA force-pushed the mplaneta/guid-type branch from 9e4c338 to eaf0a03 Compare

November 8, 2021 08:48


          [WIP] Add Guid type hiding raw ibv GUID

501c9e7

Create new Guid type that takes care of endianness conversion.

planetA force-pushed the mplaneta/guid-type branch from eaf0a03 to 501c9e7 Compare

November 8, 2021 08:52

jonhoo reviewed

View reviewed changes

ibverbs/src/lib.rs Outdated Show resolved Hide resolved

jonhoo approved these changes

View reviewed changes

ibverbs/src/lib.rs Outdated Show resolved Hide resolved

jonhoo added 2 commits

November 9, 2021 21:06


          Update ibverbs/src/lib.rs


          Update ibverbs/src/lib.rs

a9fc772

jonhoo merged commit 6037f6d into jonhoo:master

Owner

jonhoo commented Nov 10, 2021

Thanks!

jonhoo pushed a commit that referenced this pull request


          Nit: Selecting direct minimal versions flag is -Zdirect-minimal-versi…

3d6ab95

…ons (#16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet