Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Endpoint fields accessible and the Gid optional #26

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

YtvwlD
Copy link
Contributor

@YtvwlD YtvwlD commented Jan 18, 2024

I do have an existing C application I want to communicate with and I think it's not using global routing, so I have to get the (lid, qpn) information out of this library and into the other application (and back).

Because QueuePairEndpoint is already Serialize and Deserialize, I don't think that making the fields public has any serious implications (though adding getter functions and a new function might be nicer, idk).

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! Just a few smaller bits:

ibverbs/src/lib.rs Outdated Show resolved Hide resolved
ibverbs/src/lib.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e6fc6dd) 10.1% compared to head (5598ab8) 10.2%.

Additional details and impacted files
Files Coverage Δ
ibverbs/src/lib.rs 8.5% <41.6%> (+0.1%) ⬆️

@jonhoo
Copy link
Owner

jonhoo commented Jan 20, 2024

Looks like rustfmt also isn't happy with this line:

qpe.gid.as_mut().unwrap().raw = unsafe { std::mem::transmute([87_u64.to_be(), 192_u64.to_be()]) };

@YtvwlD
Copy link
Contributor Author

YtvwlD commented Jan 24, 2024

Good points. I've modified the documentation and the line in the test.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jonhoo jonhoo merged commit dbb3bd3 into jonhoo:main Jan 28, 2024
12 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Jan 28, 2024

Released as 0.7.1 🎉

@YtvwlD YtvwlD deleted the gid branch January 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants