-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Endpoint fields accessible and the Gid optional #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me! Just a few smaller bits:
Codecov ReportAttention:
Additional details and impacted files
|
Looks like rustfmt also isn't happy with this line: rust-ibverbs/ibverbs/src/lib.rs Line 1410 in 53e1782
|
Good points. I've modified the documentation and the line in the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Released as 0.7.1 🎉 |
I do have an existing C application I want to communicate with and I think it's not using global routing, so I have to get the (lid, qpn) information out of this library and into the other application (and back).
Because
QueuePairEndpoint
is alreadySerialize
andDeserialize
, I don't think that making the fields public has any serious implications (though adding getter functions and anew
function might be nicer, idk).