Implement ser/der for QueuePairEndpoint #7

iwahbe · 2021-03-31T22:46:36Z

Make QueuePairEndpoint serializable.

I use the same essential strategy (and some of the code) as @kuenishi. The reason we can't just slap a #[derive(Serialize, Deserialize)] is that QueuePairEndpoint contains a C style union, which serde does not want to mess with. I get around this by providing idiomatic conversions from/to PortableQPEndpoint, and telling serde to use PortableQPEndpoint as an intermediary for serialization and deserialization.

For a larger struct, you could implement custom serializers and deserializers, but this copy strategy works well for small structs.

I also implement fmt::Debug and PartialEq for QueuePairEndpoint.

jonhoo

Thanks! I'm a little worried about forcing the interpretation of ibv_gid as a global — raw is there for a reason. Is there maybe a way we can expose this in a way where the user has to assert that their QueuePairEndpoint is in fact using global before they can use it with PortableQPEndpoint?

src/lib.rs

Encode that `Gid` is really just a `[u8;16]`. We also just apply `serde` directly to `QueuePairEndpoint` without exposing any implementation types. We can do this because `serde` can be applied to `Gid`.

src/lib.rs

Make some recommended changes for conversion traits.

jonhoo

Thanks for sticking with all my requests for changes. Looks great now! 👍

jonhoo · 2021-04-10T02:42:43Z

Released in 0.4.5 and 0.5.0!

Implement ser/der for QueuePairEndpoint

adcdb9f

jonhoo reviewed Apr 1, 2021

View reviewed changes

Make recommended changes

0408348

iwahbe requested a review from jonhoo April 1, 2021 05:31

jonhoo mentioned this pull request Apr 6, 2021

Make QueuePairEndpoint serializable #5

Closed

Implement Gid as a native type.

3cc8d79

Encode that `Gid` is really just a `[u8;16]`. We also just apply `serde` directly to `QueuePairEndpoint` without exposing any implementation types. We can do this because `serde` can be applied to `Gid`.