New release #5
Merged
New release #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project lacked docs to help users and contributors.
There was no test workflow yet, and the release workflow could do with some improving.
A linter was introduced, so existing code needs to be made compliant
It was lacking, apparantly
Ease contributing
Revive checks for godoc (we were lacking that) and is much faster
Revive is a bit stricter than golint, so we need to fix more
Use revive linter
0 length responses previously would still try to read till end of line waiting for the EOL character for the expected response which results in a while-loop. We therefore handle this as a non-error and return silently.
Add helper functions to allow opening the device with a mask of channels, read from the device, and close the device.
Add support for buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brendan-ta has created support for buffers in #4, which should be released.