Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap missing parent assignment of {} to after last target check to av… #24

Merged
merged 2 commits into from
Apr 28, 2021
Merged

swap missing parent assignment of {} to after last target check to av… #24

merged 2 commits into from
Apr 28, 2021

Conversation

dkebler
Copy link
Contributor

@dkebler dkebler commented Jun 12, 2020

Here it be. I added three tests to that use a setter and observable and it passes all of those and your tests as long as the that parent assignement is after the break. Just swap those back and you will fail the test

BTW there was no issue with the merge option. (included a test for that).


Also I think you should include documentation readme for the currently undocumented options, (i.e. merge/function,split/separator)

FYI I have a bit more robust handler for variations of the path format. Handles also multiple delimiters. I just call before calling set it might be nice to incorporate directly to avoid unnecessary joining and splitting. Let me know if that is something you want to include and I'll make a pr for that.

…oid extraneous assignment and support setter with observable
@jonschlinkert
Copy link
Owner

Hi @dkebler, thanks for the PR and sorry for the late response. I refactored this library and will be doing a major release shortly, but I'm going to merge this anyway to acknowledge the time and effort you took to contribute.

I'll also make sure to include your suggestions in the release.

Thank you.

@jonschlinkert jonschlinkert merged commit fb3e52d into jonschlinkert:master Apr 28, 2021
@jonschlinkert
Copy link
Owner

FYI I have a bit more robust handler for variations of the path format. Handles also multiple delimiters. I just call before calling set it might be nice to incorporate directly to avoid unnecessary joining and splitting. Let me know if that is something you want to include and I'll make a pr for that.

forgot to comment on this.. if you're still interested, I think it would be easier to discuss over a PR if you feel like doing one. thanks!

@dkebler
Copy link
Contributor Author

dkebler commented May 1, 2021

glad you did that. I've been forced to use my fork.

As to improved handler It's been awhile but I'll refesh the memory cells make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants