swap missing parent assignment of {} to after last target check to av… #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it be. I added three tests to that use a setter and observable and it passes all of those and your tests as long as the that parent assignement is after the break. Just swap those back and you will fail the test
BTW there was no issue with the merge option. (included a test for that).
Also I think you should include documentation readme for the currently undocumented options, (i.e. merge/function,split/separator)
FYI I have a bit more robust handler for variations of the path format. Handles also multiple delimiters. I just call before calling set it might be nice to incorporate directly to avoid unnecessary joining and splitting. Let me know if that is something you want to include and I'll make a pr for that.