add a JavaScript kernel

jonsequitur · Aug 24, 2022 · 11f3e3b · 11f3e3b
1 parent 6dc4f45
commit 11f3e3b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 24 deletions.
diff --git a/src/dotnet-repl.Tests/Automation/NotebookRunnerTests.cs b/src/dotnet-repl.Tests/Automation/NotebookRunnerTests.cs
@@ -93,29 +93,6 @@ public async Task Notebook_runner_produces_expected_output()
         this.Assent(resultContent, _assentConfiguration);
     }
 
-    [Fact]
-    public async Task ASCII_escape_sequences_do_not_cause_XML_parse_problems()
-    {
-        using var kernel = new CSharpKernel();
-
-        var runner = new NotebookRunner(kernel);
-
-        var inputDoc = new InteractiveDocument
-        {
-            new InteractiveDocumentElement("123.Display(\"unknown/MIMEtype\");", "csharp")
-        };
-        var outputDoc = await runner.RunNotebookAsync(inputDoc);
-
-        var xml = outputDoc.ToTestOutputDocumentXml();
-
-        TestOutputDocumentParser.Parse(xml);
-
-
-
-        // TODO (ASCII_escape_sequences_do_not_cause_XML_parse_problems) write test
-        throw new NotImplementedException();
-    }
-
     private void NormalizeMetadata(InteractiveDocument document)
     {
         foreach (var element in document.Elements)

diff --git a/src/dotnet-repl/KernelBuilder.cs b/src/dotnet-repl/KernelBuilder.cs
@@ -1,5 +1,7 @@
 using System.Collections.Generic;
+using System.Threading.Tasks;
 using Microsoft.DotNet.Interactive;
+using Microsoft.DotNet.Interactive.Browser;
 using Microsoft.DotNet.Interactive.Commands;
 using Microsoft.DotNet.Interactive.CSharp;
 using Microsoft.DotNet.Interactive.FSharp;
@@ -74,8 +76,9 @@ public static CompositeKernel CreateKernel(StartupOptions? options = null)
             new KeyValueStoreKernel()
                 .UseWho());
 
+        var playwrightKernel = Task.Run(() => new PlaywrightKernelConnector().CreateKernelAsync("javascript")).Result;
+        compositeKernel.Add(playwrightKernel, new[] { "js" });
         compositeKernel.Add(new MarkdownKernel());
-
         compositeKernel.Add(new SqlDiscoverabilityKernel());
         compositeKernel.Add(new KqlDiscoverabilityKernel());
 

diff --git a/src/dotnet-repl/KernelSpecificTheme.cs b/src/dotnet-repl/KernelSpecificTheme.cs
@@ -35,6 +35,7 @@ public abstract class KernelSpecificTheme : Theme
         "csharp" => new CSharpTheme(),
         "fsharp" => new FSharpTheme(),
         "pwsh" => new PowerShellTheme(),
+        "javascript" => new JavaScriptTheme(),
         "sql" => new SqlTheme(),
         _ => null
     };
@@ -63,6 +64,15 @@ public class PowerShellTheme : KernelSpecificTheme
     public override string PromptText => "PS";
 }
 
+public class JavaScriptTheme : KernelSpecificTheme
+{
+    public override Style AccentStyle => new(Color.Yellow);
+
+    public override string KernelDisplayName => "JavaScript";
+
+    public override string PromptText => "JS";
+}
+
 public class SqlTheme : KernelSpecificTheme
 {
     public override Style AccentStyle => new(Color.Yellow3);