Unification #102
Merged
Unification #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of files are identical throughout the different packages. This is the base for unifying them for easier handling.
Some packages use 'tests' as tests directory, while other use 'Tests'. The reference in phpunit.xml.dist is adjusted accordingly.
The images used for tests with these versions have problems with using composer (giving curl error 60), so they are removed for now, until a solution is found.
Used for signing the generated .drone.yml file Generate .drone.yml
There's a bug in the lowest possible version of phpunit/phpunit-mock-objects. Therefore, that dependency gets updated separately.
The public API contains methods being named _ (e.g., joomla/language) Some libraries and APIs use snake case names, causing code style checker to complain.
As some packages irreversibly violate our code style by using underscores in variable and method names, the loose check will let names with underscore pass. This check must pass. The strict check is applied without any exceptions, but allowed to fail, so we still get informed about these violations.
Joomla.NamingConventions.ValidVariableName.NotCamelCaps was still checked.
Since the CMS has expressed a need for PHP 8.1 compatible versions of the packages from Framework 1, compatibility should also be tested.
PHPUnit 6.5 fails on PHP 8.1
This reverts commit 27ee84f71de1431043e7248a388c0989042b8b29.
Remove 'ignore-deps' directive from PHP 8 pipelines This is an attempt to find the cause for tests not even being executed under certain, yet unknown, circumstances.
Since PHPUnit in older versions requires PHP >= X.Y.Z, composer pulls version 4.8.35, which does not work.
This reverts commit a97e7bed3b32f3a71f3ee8737fe2c8e4ff471d28.
In rare cases, rounding errors occur in the formatting of the date, which lead to a deviation of 1 second in the display if the date is more than accurate to the second, as with now(). A fixed date/time specification avoids the problem.
This reverts commit 3a7b0e3f77bed481818140480a38baa1a1e967f1.
The phpunit.xml should only specify values that are required by the test environment. Everything that the tests themselves require should be made available via bootstrap.php.
The tests rely on JPATH_ROOT being defined.
The tests rely on JPATH_ROOT being defined.
Composer will use PHPUnit 4.8.36 otherwise.
A lot of files are identical throughout the different packages. This is the base for unifying them for easier handling.
Some packages use 'tests' as tests directory, while other use 'Tests'. The reference in phpunit.xml.dist is adjusted accordingly.
The images used for tests with these versions have problems with using composer (giving curl error 60), so they are removed for now, until a solution is found.
Used for signing the generated .drone.yml file Generate .drone.yml
Used for signing the generated .drone.yml file Generate .drone.yml
There's a bug in the lowest possible version of phpunit/phpunit-mock-objects. Therefore, that dependency gets updated separately.
The public API contains methods being named _ (e.g., joomla/language) Some libraries and APIs use snake case names, causing code style checker to complain.
Used for signing the generated .drone.yml file Generate .drone.yml
There's a bug in the lowest possible version of phpunit/phpunit-mock-objects. Therefore, that dependency gets updated separately.
As some packages irreversibly violate our code style by using underscores in variable and method names, the loose check will let names with underscore pass. This check must pass. The strict check is applied without any exceptions, but allowed to fail, so we still get informed about these violations.
Joomla.NamingConventions.ValidVariableName.NotCamelCaps was still checked.
Since the CMS has expressed a need for PHP 8.1 compatible versions of the packages from Framework 1, compatibility should also be tested.
PHPUnit 6.5 fails on PHP 8.1
This reverts commit 27ee84f71de1431043e7248a388c0989042b8b29.
Remove 'ignore-deps' directive from PHP 8 pipelines This is an attempt to find the cause for tests not even being executed under certain, yet unknown, circumstances.
Since PHPUnit in older versions requires PHP >= X.Y.Z, composer pulls version 4.8.35, which does not work.
This reverts commit a97e7bed3b32f3a71f3ee8737fe2c8e4ff471d28.
In rare cases, rounding errors occur in the formatting of the date, which lead to a deviation of 1 second in the display if the date is more than accurate to the second, as with now(). A fixed date/time specification avoids the problem.
This reverts commit 3a7b0e3f77bed481818140480a38baa1a1e967f1.
The phpunit.xml should only specify values that are required by the test environment. Everything that the tests themselves require should be made available via bootstrap.php.
The tests rely on JPATH_ROOT being defined.
The tests rely on JPATH_ROOT being defined.
Composer will use PHPUnit 4.8.36 otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to prepare for use with the Monorepo
Summary of Changes
Use templates for files present in all projects
Adjustments were made to .drone.jsonnet and phpunit.xml.dist to adapt them to the layout of the file system.
Testing Instructions
Code review only, since the package's code is untouched.
Documentation Changes Required
No.