Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check types of postgres default values if set #259

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jan 9, 2022

The field default can be null. If that is the case then the preg_match gives a PHP deprecation warning in PHP 8.1.

This can be seen at https://ci.joomla.org/joomla/joomla-cms/50349/1/31 phpnext-api-postgres test run

e.g.

  <b>Deprecated</b>:  preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in <b>/tests/www/postgresphpnext/libraries/vendor/joomla/database/src/Pgsql/PgsqlDriver.php</b> on line <b>273</b><br />
  <br />
  <b>Deprecated</b>:  preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in <b>/tests/www/postgresphpnext/libraries/vendor/joomla/database/src/Pgsql/PgsqlDriver.php</b> on line <b>279</b><br />

@alikon alikon mentioned this pull request Jan 9, 2022
@alikon
Copy link
Contributor

alikon commented Jan 9, 2022

we have 2 pr for this issue the 1st #258

@alikon
Copy link
Contributor

alikon commented Jan 9, 2022

can we have merged at least one please

@nibra nibra merged commit b2535b1 into 2.0-dev Jan 9, 2022
@nibra nibra deleted the fix/php81-pgsql-defaults branch January 9, 2022 11:09
@wilsonge
Copy link
Contributor Author

wilsonge commented Jan 9, 2022

Oops my bad. Was going through drone issues last night, missed the other one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants