Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPv6 addresses with brackets for pgsql #315

Closed
wants to merge 1 commit into from

Conversation

muhme
Copy link

@muhme muhme commented Oct 7, 2024

🚧 DRAFT as to be extended by unit tests and documentation

Summary of Changes

IPv6 addresses are used with square brackets for MySQL and MariaDB and allowing the configuration of a non-default port number for the IPv6 address. However, with PostgreSQL, square brackets around IPv6 addresses are not usable, and setting a port is not possible.

Since it was decided to have only a single host field without a separate port number field in Joomla Web Installer (see issue #43902), there is a need to use square brackets to distinguish between the IPv6 host address and a port number.

This PR removes the square brackets somewhere in the middle, after separating a possible port number, but before continuing with PostgreSQL:

  • PostgreSQL can now use IPv6 addresses with square brackets, just like MariaDB and MySQL → simplifies/unifies documentation and joomla-cypress-36 implementation
  • For the first time, it is possible to configure a port number together with an IPv6 address for PostgreSQL.
  • The change is fully backward compatible. In the past, IPv6 addresses were accepted without square brackets, and this will continue to be supported in the future as well.

Testing Instructions

🚧 DRAFT For the moment together with and will be added to joomla-cypress-36

Documentation Changes Required

TODO

This unifies with MySQL and MariaDB and allows to set port number.
@muhme
Copy link
Author

muhme commented Oct 30, 2024

This PR has been replaced by the alternative #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants