Prepared statement support for SQL Server #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we kill the composer cache in the .appveyor.yml file I think that is the root of the |
|
@wilsonge Review/Merge this so we can finally tag a release here. |
wilsonge
reviewed
Jan 29, 2017
| { | ||
| $array = array(); | ||
| $bounded =& $this->sql->getBounded(); |
There was a problem hiding this comment.
What's the reason for this being via reference?
There was a problem hiding this comment.
To be perfectly honest, not a clue. It's how the other implementations do it though, so I assume there was a reason at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This completes having all of the package's drivers support prepared statements by adding support for the driver it was missing in; SQL Server.
Testing Instructions
Use the
testExecutePreparedStatementcase as an example of how to bind variables for use in a prepared query.Documentation Changes Required
N/A