Fix the loading of the table columns #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second argument was missing so the fields were loaded as type only but the code is expecting the full information. Setting the second argument to false, loads all details and the test on line 132 will not throw notices because $column is now an object.
|
@mbabker Can we get this into 3.7? |
|
@mbabker Any news on this? This bug breaks the importer. |
|
Well, even when merged here it would still have to be patched separate in the CMS because the CMS isn't yet using this code. So to get it in 3.7 you'll need to patch there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The second argument was missing so the fields were loaded as type only but the code is expecting the full information. Setting the second argument to false, loads all details and the test on line 132 will not throw notices because $column is now an object.
Testing Instructions
Try to import the XML schema for a database table for an existing table. There will be several notices Notice: Trying to get property of non-object in D:\wamp64\www\joomla-cms\libraries\joomla\database\importer\mysqli.php on line 148
Apply the patch
The import now runs without any notices.
Documentation Changes Required
None