Store Date as UTC and show it in server time zone #57

astridx · 2018-07-26T08:40:50Z

Pull Request for Issue #52 (comment).

Summary of Changes

The values for modified and created date are stored in UTC, but shown in server time zone.
If your server time zone is Australia

you see this time:

If your server time zone is in Europe

you see this time:

For Europe you see in the view this values:

In the database the UTC values are stored

laoneo · 2018-07-26T08:44:41Z

administrator/components/com_templates/Model/TemplateModel.php

+		{
+			if ((int) $result->created_date)
+			{
+				$created_date = new Date($result->created_date);


In what for a timezone is $result->created_date?

astridx · 2018-07-26T09:49:06Z

plugins/installer/override/override.php

@@ -336,10 +336,8 @@ private function saveOverrides($pks)
 		{
 			$insertQuery->clear('values');

-			$tz = new \DateTimeZone(Factory::getApplication()->get('offset'));
 			$date = new Date('now');


@laoneo If I am right the timezone of $date = new Date('now');
is UTC as this is the default time zone.

I guess so too.

anuragteapot · 2018-07-26T13:07:50Z

@astridx Can we do this without creating a new loop ? Mean, here

gsoc18_override_management/administrator/components/com_templates/Model/TemplateModel.php

Line 202 in 2c393ff

$results[] = $pk;

anuragteapot · 2018-07-26T13:09:19Z

administrator/components/com_templates/Model/TemplateModel.php

+		// Get timezone for converting the created and modified date.
+		$tz = new \DateTimeZone(Factory::getApplication()->get('offset'));
+
+		foreach ($results as $result)


astridx · 2018-07-26T14:22:09Z

Can we do this without creating a new loop ? Mean, here

@Anu1601CS I have put the code in the already existing loop.

@laoneo Is the handling of the date now like it should be done in Joomla?

mbabker · 2018-07-26T14:46:01Z

administrator/components/com_templates/Model/TemplateModel.php

+				if ((int) $pk->created_date)
+				{
+					$created_date = new Date($pk->created_date);
+					$created_date->setTimezone($tz);


These setTimezone calls should not be necessary. Instantiating a new Joomla\CMS\Date\Date object internally converts the timestamp to UTC.

mbabker · 2018-07-26T14:47:05Z

administrator/components/com_templates/Model/TemplateModel.php

+				{
+					$created_date = new Date($pk->created_date);
+					$created_date->setTimezone($tz);
+					$pk->created_date = $created_date->toSql(true);


toSql(true) means you're getting the timestamp in the correct SQL format but localized, so this is converting from UTC to whatever timezone you're setting above.

Look at the check methods of various Joomla\CMS\Table\Table subclasses for how created and modified dates are handled.

@mbabker Thank you for your help. But if I do not set the timezone, the date will be displayed in UTC.

Sorry, missed this wasn't a save operation.

The timezone shouldn't be normalized in models. This should be done in views/layouts. So you should use the JHtml::date() helper (as is done elsewhere in core) for this, as that will adjust the timezone for the user's configuration.

astridx · 2018-07-26T15:34:16Z

I moved normalizing of the timezone to the view

anuragteapot · 2018-07-26T20:06:57Z

@dgrammatiko Javascript test fails with.

ReferenceError: customElements is not defined
at http://localhost:9876/base/media/system/webcomponents/js/joomla-field-switcher-es5.js?8673eb07a3064c4b3028e5260638e1e20334404b:265
Firefox 59.0.0 (Ubuntu 0.0.0) ERROR
ReferenceError: customElements is not defined
at /drone/src/github.com/joomla-projects/gsoc18_override_management/media/system/webcomponents/js/joomla-field-switcher-es5.js:265

laoneo · 2018-07-26T20:41:26Z

administrator/components/com_templates/tmpl/template/default_updated_files.php

@@ -57,13 +57,15 @@
 									<a class="hasTooltip" href="<?php echo Route::_('index.php?option=com_templates&view=template&id=' . (int) $value->extension_id . '&file=' . $value->hash_id); ?>" title="<?php echo Text::_('JACTION_EDIT'); ?>"><?php echo base64_decode($value->hash_id); ?></a>
 								</td>
 								<td>
-									<?php echo $value->created_date; ?>
+									<?php $created_date = $value->created_date; ?>
+									<?php echo $created_date > 0 ? HTMLHelper::_('date', $created_date, 'Y-m-d H:i:s') : '-'; ?>


There are language constants for date formats. I'm not sure but the custom field is using them.

…rrectingDates

…erride_management into astrid_correctingDates

astridx · 2018-07-27T07:40:20Z

Now I use language constants for date format.

dgrammatiko · 2018-07-27T20:17:11Z

@Anu1601CS the js tests should be ok for now

laoneo · 2018-07-28T04:57:55Z

Thanks.

anuragteapot · 2018-07-28T05:18:09Z

@astridx Thank you very much :)

astridx · 2018-07-28T07:08:57Z

Thanks. And now I understand why we store date in UTC. Up to know this was not clear to me. (I even found this unnecessary work to store a value in UTC just to convert the value back to the time zone later).
But now I had a closer look and I understand, that we do this to show the value in the user time zone - if this is set. If the user time zone is not set, we show it in the server time zone. And

it's easier to do this from the fixed time-zone UTC than always need to count between different time zones.
in the case of stored data you do not know in which time zone the date is stored - because it could be, that someone changed the timezone in the Joomla config.

I hope I understood this right.

@laoneo Is everything in this repo correct again? I mean, are all issues you see here are now OK: #52 (comment)

By the way: Is there a documentation about that? I only found: https://docs.joomla.org/How_to_use_JDate what is not very detailed ....

laoneo · 2018-07-28T09:16:12Z

Yes, that's the way to go with dates, always UTC.

* Load correct core files of override files (#2) Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php * CS (#3) Coding Standards * codingstandards * codingstandards (#4) * Test (#6) Phase 2 (2 part) Mechanism to find correct core file and implementation. * Remove Notice: Only available for html-folder * Remove Warning if core file not found (#11) Thanks. So one part of the issue #12 is done. * Implement the diff view in template manager Implement the diff view in template manager * coding standard (#17) * fix diff (#18) Fix bug in path in case of administrator template override. Fix bug in path in case of administrator template override. * Notification after update and TEST (#16) Find changed files of overridden files and show message. * coding standard (#21) * correction * correction (#26) * Correcthtmlpath (#27) * correction * change oldhtml to newhtml * List of updated override files. (#30) * addcss (#34) * Final Product (#39) Core and Diff view Updated override history list. Quick icon notification plugin. Override control plugin. * save 3 lines :) * New feature show status. (#47) show status in com_template view templates * link * corrected namespace * Button to Switch (#35) * wip add Switcher * wip style switcher * wip style switch make inline and change on off text * wip start with js * wip js * wip delete buttons and make js more robust * wip save to storage * wip delete old code * wip * wip lint * wip css * set default value for switcher * wip make switcher blue * wip * wip * build * correct names * create new functions * fist test code * use onchange * undo installer.min.js * add forgotten new line at the end of css file * correct align * correct compare.es6 - only deleted the toggle part * correct compare.js - only deleted the toggle part * wip * reduce timeout * wrap in funcitons * wip * add use strict to both js-files(compare and toggle) * add the timeout value of 500 again, because 200 are not enought in my case * use css class 'active' for toggle views * add strict * time out for editor * wip * improvments use newActive and switch * correction * width of switcher-spans * correct align * do not use global * wip * removed timeouts * JTEXT to TEXT * forgotton last line * deleted duplicated comments * css fix align * use unnamed functions in es6 * Sql files for fix database (#50) * sql files for database fix * delete space * Suggestion for displaying Dates in view updates files (#52) Correct Dates and do not use date of file any more * Store Date as UTC and show it in server time zone (#57) * modified and created date are created and stored in UTC * convert dates for displaying in model * spar a loop * normalize timezone in view * use language constants for dateformat * JToolbarHelper to ToolbarHelper * CS * namespace * plural * name * clean * text * fx * sin * files * s * Suggestion for language strings (#60) * language strings * correct typo * delete media folder plg_quickicon * add folder plg_quickicon to build/media_src * delete files in media folder * Move media folder - System (#66) * multi * cs * delete files in media folder for joomla toolbar (#67) * Fix button switchers style. (#70) * button * CS * changed uitab.addTab for updated files * Bring back core.js changes. (#69) * core.js * const * fix * form * core * hound * CS * scopr * grid * alpha * cs * lang * only override file * lang * override lang installer * Cs * sub * Update list of core extensions (#71) * Language changes (#76) * update * Update en-GB.com_templates.ini * override JLIB_HTML_PUBLISH_ITEM this is the hover text on the publish icon in the list of files * Change icon (#74) change the icon to use an outline for more consistency * lang * not core (#75) * not core * Update en-GB.plg_installer_override.ini * namespace * cs * Updated files (#82) * Update default_updated_files.php * Update en-GB.com_templates.ini * Update en-GB.com_templates.ini (#81) * Update en-GB.plg_quickicon_overridecheck.ini (#80) * Update en-GB.plg_quickicon_overridecheck.ini (#79) * remove space (#78) * Update en-GB.plg_quickicon_overridecheck.ini * Update en-GB.plg_quickicon_overridecheck.sys.ini * remove hardcoded id * null get function * state * clean * More changes "core" to "original" (#85) * cs * update * plural

astridx added 2 commits July 26, 2018 09:59

modified and created date are created and stored in UTC

8c4ccc1

convert dates for displaying in model

e9028f3

laoneo reviewed Jul 26, 2018

View reviewed changes

astridx commented Jul 26, 2018

View reviewed changes

anuragteapot reviewed Jul 26, 2018

View reviewed changes

spar a loop

a44cc6e

mbabker reviewed Jul 26, 2018

View reviewed changes

normalize timezone in view

9edba2d

laoneo reviewed Jul 26, 2018

View reviewed changes

astridx added 3 commits July 27, 2018 09:32

use language constants for dateformat

d4a4478

Merge branch '4.0-dev' of github.com:joomla/joomla-cms into astrid_co…

0548ac8

…rrectingDates

Merge branch 'master' of https://github.com/joomla-projects/gsoc18_ov…

2f24aa9

…erride_management into astrid_correctingDates

laoneo merged commit 71fc7bb into master Jul 28, 2018

laoneo deleted the astrid_correctingDates branch July 28, 2018 04:57

anuragteapot added the enhancement Small enhancemenet label Jul 28, 2018

anuragteapot assigned astridx Jul 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Store Date as UTC and show it in server time zone #57

Store Date as UTC and show it in server time zone #57

astridx commented Jul 26, 2018

laoneo Jul 26, 2018 •

edited

Loading

astridx Jul 26, 2018

laoneo Jul 26, 2018

anuragteapot commented Jul 26, 2018 •

edited

Loading

anuragteapot Jul 26, 2018

astridx commented Jul 26, 2018

mbabker Jul 26, 2018

mbabker Jul 26, 2018

astridx Jul 26, 2018

mbabker Jul 26, 2018

astridx commented Jul 26, 2018

anuragteapot commented Jul 26, 2018

laoneo Jul 26, 2018

astridx commented Jul 27, 2018

dgrammatiko commented Jul 27, 2018

laoneo commented Jul 28, 2018

anuragteapot commented Jul 28, 2018

astridx commented Jul 28, 2018 •

edited

Loading

laoneo commented Jul 28, 2018

Store Date as UTC and show it in server time zone #57

Store Date as UTC and show it in server time zone #57

Conversation

astridx commented Jul 26, 2018

Summary of Changes

laoneo Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuragteapot commented Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

astridx commented Jul 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astridx commented Jul 26, 2018

anuragteapot commented Jul 26, 2018

Choose a reason for hiding this comment

astridx commented Jul 27, 2018

dgrammatiko commented Jul 27, 2018

laoneo commented Jul 28, 2018

anuragteapot commented Jul 28, 2018

astridx commented Jul 28, 2018 • edited Loading

laoneo commented Jul 28, 2018

laoneo Jul 26, 2018 •

edited

Loading

anuragteapot commented Jul 26, 2018 •

edited

Loading

astridx commented Jul 28, 2018 •

edited

Loading