[5.2] Remove alt-text for menuItem with image and title (#40675)

joomla · Jan 18, 2025 · b337054 · b337054
1 parent 7c11cd0
commit b337054
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 20 deletions.
diff --git a/modules/mod_menu/tmpl/default_component.php b/modules/mod_menu/tmpl/default_component.php
@@ -54,11 +54,9 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
-    if ($itemParams->get('menu_text', 1)) {
-        $linktype .= '<span class="image-title">' . $item->title . '</span>';
-    }
+    $linktype .= '<span class="image-title' . ($itemParams->get('menu_text', 1) ? '' : ' visually-hidden') . '">' . $item->title . '</span>';
 }
 
 if ($item->browserNav == 1) {

diff --git a/modules/mod_menu/tmpl/default_heading.php b/modules/mod_menu/tmpl/default_heading.php
@@ -33,7 +33,7 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
     if ($itemParams->get('menu_text', 1)) {
         $linktype .= '<span class="image-title">' . $item->title . '</span>';

diff --git a/modules/mod_menu/tmpl/default_separator.php b/modules/mod_menu/tmpl/default_separator.php
@@ -33,7 +33,7 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
     if ($itemParams->get('menu_text', 1)) {
         $linktype .= '<span class="image-title">' . $item->title . '</span>';

diff --git a/modules/mod_menu/tmpl/default_url.php b/modules/mod_menu/tmpl/default_url.php
@@ -46,11 +46,9 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
-    if ($itemParams->get('menu_text', 1)) {
-        $linktype .= '<span class="image-title">' . $item->title . '</span>';
-    }
+    $linktype .= '<span class="image-title' . ($itemParams->get('menu_text', 1) ? '' : ' visually-hidden') . '">' . $item->title . '</span>';
 }
 
 if ($item->browserNav == 1) {

diff --git a/templates/cassiopeia/html/mod_menu/dropdown-metismenu_component.php b/templates/cassiopeia/html/mod_menu/dropdown-metismenu_component.php
@@ -54,11 +54,9 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
-    if ($itemParams->get('menu_text', 1)) {
-        $linktype .= '<span class="image-title">' . $item->title . '</span>';
-    }
+    $linktype .= '<span class="image-title' . ($itemParams->get('menu_text', 1) ? '' : ' visually-hidden') . '">' . $item->title . '</span>';
 }
 
 if ($item->browserNav == 1) {

diff --git a/templates/cassiopeia/html/mod_menu/dropdown-metismenu_heading.php b/templates/cassiopeia/html/mod_menu/dropdown-metismenu_heading.php
@@ -41,7 +41,7 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
     if ($itemParams->get('menu_text', 1)) {
         $linktype .= '<span class="image-title">' . $item->title . '</span>';

diff --git a/templates/cassiopeia/html/mod_menu/dropdown-metismenu_separator.php b/templates/cassiopeia/html/mod_menu/dropdown-metismenu_separator.php
@@ -41,7 +41,7 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
     if ($itemParams->get('menu_text', 1)) {
         $linktype .= '<span class="image-title">' . $item->title . '</span>';

diff --git a/templates/cassiopeia/html/mod_menu/dropdown-metismenu_url.php b/templates/cassiopeia/html/mod_menu/dropdown-metismenu_url.php
@@ -46,11 +46,9 @@
         $image_attributes['class'] = $item->menu_image_css;
     }
 
-    $linktype = HTMLHelper::_('image', $item->menu_image, $item->title, $image_attributes);
+    $linktype = HTMLHelper::_('image', $item->menu_image, '', $image_attributes);
 
-    if ($itemParams->get('menu_text', 1)) {
-        $linktype .= '<span class="image-title">' . $item->title . '</span>';
-    }
+    $linktype .= '<span class="image-title' . ($itemParams->get('menu_text', 1) ? '' : ' visually-hidden') . '">' . $item->title . '</span>';
 }
 
 if ($item->browserNav == 1) {