use early returns

joomla · Jul 26, 2024 · d357b4c · d357b4c
1 parent 9c234b5
commit d357b4c
Showing 1 changed file with 27 additions and 24 deletions.
diff --git a/administrator/components/com_media/resources/scripts/store/mutations.es6.js b/administrator/components/com_media/resources/scripts/store/mutations.es6.js
@@ -172,31 +172,34 @@ export default {
       );
     }
 
-    // Automatically select the last uploaded item when media manager is inside an iframe
-    if (window.location !== window.parent.location) {
-      if (state.files.length) {
-        const selectedFile = state.files.find((item) => item.name === file.name);
-        if (selectedFile) {
-          state.selectedItems = [selectedFile];
-
-          window.parent.document.dispatchEvent(
-            new CustomEvent('onMediaFileSelected', {
-              bubbles: true,
-              cancelable: false,
-              detail: {
-                type: selectedFile.type,
-                path: selectedFile.path,
-                thumb: selectedFile.thumb,
-                fileType: selectedFile.mime_type ? selectedFile.mime_type : false,
-                extension: selectedFile.extension ? selectedFile.extension : false,
-                width: selectedFile.width ? selectedFile.width : 0,
-                height: selectedFile.height ? selectedFile.height : 0,
-              },
-            }),
-          );
-        }
-      }
+    // Automatically select the last uploaded item when the media manager is inside an iframe
+    if (window.location === window.parent.location || !state.files.length) {
+      return;
+    }
+
+    const selectedFile = state.files.find((item) => item.name === file.name);
+
+    if (!selectedFile) {
+      return;
     }
+
+    state.selectedItems = [selectedFile];
+
+    window.parent.document.dispatchEvent(
+      new CustomEvent('onMediaFileSelected', {
+        bubbles: true,
+        cancelable: false,
+        detail: {
+          type: selectedFile.type,
+          path: selectedFile.path,
+          thumb: selectedFile.thumb,
+          fileType: selectedFile.mime_type ? selectedFile.mime_type : false,
+          extension: selectedFile.extension ? selectedFile.extension : false,
+          width: selectedFile.width ? selectedFile.width : 0,
+          height: selectedFile.height ? selectedFile.height : 0,
+        },
+      }),
+    );
   },
 
   /**