New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html5] Beez3 frontend template #10640

Merged

roland-d merged 3 commits into joomla:staging from andrepereiradasilva:html5-beez3

Jun 25, 2016

Contributor

andrepereiradasilva commented May 26, 2016 •

edited by joomla-cms-bot

Loading

Summary of Changes

This is a redo of #9842 for beez3 only.

This PR does a basic conversion of beez3 template to HTML5.
Also made some minor corrections:

Use the API in inline css/js (except error page)
Use ie9 or lower hml5.js in all files.

Testing Instructions

Install patch
Set the site template as "beez3" (if not yet)
Go to frontend and check if the the following pages are working properly:
- normal page (test any existent URL)
- component popup (add ?tmpl=component&print=1 to an existent page)
- error pages (test one non existent URL)

Check also the code changes.

Observations

All pages should now start with this code:

<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
    <meta charset="utf-8" />
[...]


          beez3 to html5

c038a37

joomla-cms-bot added the PR-staging label

ghost commented Jun 12, 2016

I have tested this item ✅ successfully on c038a37

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}


          use $this instead of $doc

joomla-cms-bot commented Jun 17, 2016

This PR has received new commits.

CC: @bertmert

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}


          Merge remote-tracking branch 'refs/remotes/joomla/staging' into html5…

c38bda6

…-beez3

joomla-cms-bot commented Jun 17, 2016

This PR has received new commits.

CC: @bertmert

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}

Contributor Author

andrepereiradasilva commented Jun 17, 2016 •

edited

Loading

changes made:

Updated branch
removed $doc in favour of $this

anjahage commented Jun 25, 2016

I have tested this item ✅ successfully on c38bda6

Another successful test according the test instructions.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}

Contributor Author

andrepereiradasilva commented Jun 25, 2016

@bertmert can you retest?

ghost commented Jun 25, 2016

I have tested this item ✅ successfully on c38bda6

Tested successfully

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}

Contributor

zero-24 commented Jun 25, 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.}

joomla-cms-bot added the RTC label

roland-d added this to the Joomla 3.6.0 milestone

Contributor

roland-d commented Jun 25, 2016

Thanks everybody

roland-d merged commit 2f09d60 into joomla:staging

joomla-cms-bot removed the RTC label

andrepereiradasilva deleted the html5-beez3 branch

June 25, 2016 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet