Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Polyfill js for legacy browsers (adds events and classlist polyfills) #11686

Closed
wants to merge 12 commits into from
Closed

[RFC] Polyfill js for legacy browsers (adds events and classlist polyfills) #11686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9e95480
poly fill events for ie8
andrepereiradasilva Aug 20, 2016
534bfff
Update behavior.php
andrepereiradasilva Aug 20, 2016
9f14eeb
doc
andrepereiradasilva Aug 20, 2016
58bcb92
use gated polyfill so we don't have errors if somehow already exists
andrepereiradasilva Aug 20, 2016
b7fd536
Update polyfill.event-uncompressed.js
andrepereiradasilva Aug 20, 2016
f82184b
Update polyfill.event.js
andrepereiradasilva Aug 20, 2016
d71b4ef
add classList polyfill
andrepereiradasilva Aug 20, 2016
05729b2
no default values
andrepereiradasilva Aug 20, 2016
e94b21b
update to match #11289 JHtml script behaviour
andrepereiradasilva Aug 21, 2016
0b51639
'createEvent' in document
andrepereiradasilva Aug 21, 2016
e3c31c2
'createEvent' in document
andrepereiradasilva Aug 21, 2016
c8781ba
Update polyfill.event.js
andrepereiradasilva Aug 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions libraries/cms/html/behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,4 +960,46 @@ public static function tabstate()
JHtml::_('script', 'system/tabs-state.js', false, true);
self::$loaded[__METHOD__] = true;
}

/**
* Add javascript polyfills.
*
* @param string|array $polyfillTypes The polyfill type(s). Examples: event, array('event', 'classlist').
* @param array $conditionalBrowser A IE conditional expression. Example: lt IE 9 (lower than IE 9).
*
* @return void
*
* @since __DEPLOY_VERSION__
*/
public static function polyfill($polyfillTypes = null, $conditionalBrowser = null)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm how about lt IE 11 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classList partial implementation in IE 10-9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually think it's better to leave the parameters empty by default (add if you want when calling)
i will remove the default values.

if (is_null($polyfillTypes))
{
return false;
}

if (!is_array($polyfillTypes))
{
$polyfillTypes = array($polyfillTypes);
}

foreach ($polyfillTypes as $polyfillType)
{
$sig = md5(serialize(array($polyfillType, $conditionalBrowser)));

// Only load once
if (isset(static::$loaded[__METHOD__][$sig]))
{
continue;
}

// If include according to browser.
$scriptOptions = !is_null($conditionalBrowser) ? array('relative' => true, 'conditional' => $conditionalBrowser) : array('relative' => true);

JHtml::_('script', 'system/polyfill.' . $polyfillType . '.js', $scriptOptions);

// Set static array
static::$loaded[__METHOD__][$sig] = true;
}
}
}
Loading