-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Media field lightbox in subform #11760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.
Can't find this on JIssues, so marking this test as successful here |
Just reported it to jissues @C-Lodder joomla/jissues#871 |
I have tested this item ✅ successfully on 8843ffd This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760. |
@C-Lodder i have just added you test This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760. |
bot is sleeping! |
No it's not. We're fighting with ModSecurity yet again. |
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11755
Summary of Changes
This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.
Testing Instructions
Create ../modules/mod_login/text.xml to which add the following...
Add the following to the mod_login.xml file:
Then in the Module Manager, open the Login module. Add a number of subforms extending the page height. Click 'Select' in the last subform.
Before patch
After Patch