-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE drag&drop toolbar editing #11926
Conversation
Conflicts: plugins/editors/tinymce/tinymce.php
Conflicts: plugins/editors/tinymce/tinymce.php
Conflicts: plugins/editors/tinymce/tinymce.php plugins/editors/tinymce/tinymce.xml
@brianteeman @infograf768 is it what you asked in #10996? |
@Fedik the drone tests should pass if we sync to staging :) |
Conflicts: plugins/editors/tinymce/tinymce.php
fixed |
Great. Thanks. I will try to get more testers for this as I really want to
see this in core.
|
it will take higher, or last in the order https://github.com/Fedik/joomla-cms/blob/e5cc7cc45e75156e331979f84463cf79ee17dc8c/plugins/editors/tinymce/tinymce.php#L174 |
Alternatively and If you are using a flat acl because you are doing role based acl you can also just create new editor groups. Basic editor, advanced editor etc |
Does that mean that in the case above, Managers would get the Special access setting? |
it will take the last one from the array of the user view levels, that come from |
I have tested this item ✅ successfully on 58eb3bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11926. |
Thank you @Fedik |
Summary of Changes
The pull request add ability to drag&drop toolbar editing to help to configure TinyMCE editor.
How it works
How to add button to my toolbar?
Drag the button from Source panel (1) to Target panel (2), and drop it there.
How to remove the button?
Drag&drop unneeded button out of the Target panel (2).
I want more Sets!!!
Set the amount of sets in the advanced tab. A new sets will appears after save.
Testing Instructions
it does not ready for final testFirst of all make sure if the drag&drop editing works.
Then need to check that all existing features still works, as here is huge code changes.
Documentation Changes Required
Update info about how to configure TinyMCE plugin (if there any).
B. C.
It can break half of user settings for TinyMCE plugin. So need to test each case: new installation, update.
After upgrade or on clear installation the editor will use next default presets:
Help neededI made 3 presets: Simple, Medium, Advanced.Would be cool if someone will improve them, and make it more real for what user need.Also would be cool if they will be similar to "old toolbar", so we will keep B/C a little bit😉It is easy to edit, just add needed buttons in: https://github.com/Fedik/joomla-cms/blob/0b4d803c35c3995934b017f74496d0c3c26f8bb0/plugins/editors/tinymce/tinymce.php#L1064-L1106P.S.
I found that make editing depend from "view level" is not as good as I thought on start😄So I have an idea to change it a bit. And make a "Presets" so user can set access level for each "Preset". Also it will allow to use separated "Preset" for each userIt is already implemented 😉I would like to hear the feedback 😉
The pull depending from #11157. But can be tested stand alone.