fix some cs issues in the 3.7. branch #12011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test should be sufficient for this :) |
|
Looks like a lot more than codestyle to me. CS is changing tabs to spaces and new lines. This is different code |
|
|
||
| $display = $item->text; | ||
| $item->text .= $addText ? $addText : ''; |
There was a problem hiding this comment.
Too early here. Must be after switch. E.g.: See line $item->text = JText::_('JPREVIOUS'); later.
|
As an aside: Lots of these CS issues and code are taken over 1:1 from /layouts/pagination/link.php and links.php. Should be fixed there, too(?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request after Commit fc41a23
Summary of Changes
Some CS after the last commit: fc41a23
Testing Instructions
Documentation Changes Required
None