Code

Work on Site components#12261

Code

Closed

frankmayer wants to merge 19 commits intojoomla:stagingjoomla/joomla-cms:stagingfrom frankmayer:site_componentsCopy head branch name to clipboard

+372-381

Commits

Commits on Oct 2, 2016

• Elvis

  frankmayer

  committed
  2aa44e9

  Copy full SHA for 2aa44e9

• Merge nested positive ifs

  frankmayer

  committed
  cafbc0b

  Copy full SHA for cafbc0b

• Replaced some " with ' and proposed HEREDOC for bigger SQL Statements, otherwise concatenated. The issue here ,is of course what's the best way to deal with complicated conditions or otherwise dyna…

  Show description for 330d82c
  frankmayer

  committed
  330d82c

  Copy full SHA for 330d82c

• Removed unnecessary parentheses

  frankmayer

  committed
  22859e7

  Copy full SHA for 22859e7

• Removed senseless return;

  frankmayer

  committed
  66f954e

  Copy full SHA for 66f954e

• Inline one-time use variables

  frankmayer

  committed
  585bbc8

  Copy full SHA for 585bbc8

• Optimized non-optimal if conditions

  frankmayer

  committed
  be1c3f8

  Copy full SHA for be1c3f8

• Fixed callable call in loop termination condition

  frankmayer

  committed
  7e6df29

  Copy full SHA for 7e6df29

• Replaced is_null() with ===

  frankmayer

  committed
  2ad8098

  Copy full SHA for 2ad8098

• Fixed non-optimal regular expressions

  frankmayer

  committed
  f0c7392

  Copy full SHA for f0c7392

• Short syntax for applied operation

  frankmayer

  committed
  d6c7e42

  Copy full SHA for d6c7e42

• Do not use strlen to check for empty string

  frankmayer

  committed
  b89b4e1

  Copy full SHA for b89b4e1

• Replace strstr() with strpos() for some cases

  frankmayer

  committed
  656a9c2

  Copy full SHA for 656a9c2

• Replace some substr() with strpos()

  frankmayer

  committed
  79c41e3

  Copy full SHA for 79c41e3

• Merge unset statements

  frankmayer

  committed
  7a93567

  Copy full SHA for 7a93567

• Remove silly assignment 😄

  frankmayer

  committed
  94a33cf

  Copy full SHA for 94a33cf

• Made string comparisons type safe

  frankmayer

  committed
  f575776

  Copy full SHA for f575776

• More type safe comparisons

  frankmayer

  committed
  e11305b

  Copy full SHA for e11305b

• Codesniffer...

  frankmayer

  committed
  0d5b62c

  Copy full SHA for 0d5b62c