-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix less / css #12548
fix less / css #12548
Conversation
The input-prepend stuff is related to this PR that was merged lately: #12442 |
Btw: https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/less/bootstrap-extended.less#L376-L383 doesn't look right (and is also related to the mentioned PR). |
@ciar4n can you take a look here? |
I have tested this item ✅ successfully on 3e6bd2c @Bakual I emptied these selectors for #12442 . As empty selectors are ignored by LESS, I didn't bother removing them. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548. |
You should have, as empty selectors are useless 😄 |
@Bakual True :) They are not outputted to the CSS so no ill effect for the time been. I'll remove them at the next given chance. |
@zero-24 @Bakual can you guys test this so we can get it merged and then other PRs wont be effected by this error This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548. |
I have tested this item ✅ successfully on 3e6bd2c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548. |
Thanks |
recompile less using our generatecss.php script
Most changes seem to be codestyle - i guess someone used a different less compiler
BUT check the changes to input-prepend