Various changes in libraries/cms #13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
approved these changes
Dec 15, 2016
6 tasks
# Conflicts: # libraries/cms/component/router/rules/standard.php
|
Conflicts resolved. Pls check and merge. |
Quy
reviewed
Apr 26, 2017
libraries/cms/html/behavior.php
Outdated
| @@ -294,7 +294,7 @@ public static function tooltip($selector = '.hasTip', $params = array()) | |||
| $opt['showDelay'] = (isset($params['showDelay'])) ? (int) $params['showDelay'] : null; | |||
| $opt['hideDelay'] = (isset($params['hideDelay'])) ? (int) $params['hideDelay'] : null; | |||
| $opt['className'] = (isset($params['className'])) ? $params['className'] : null; | |||
| $opt['fixed'] = (isset($params['fixed']) && ($params['fixed'])) ? true : false; | |||
| $opt['fixed'] = (isset($params['fixed']) && ($params['fixed'])); | |||
There was a problem hiding this comment.
Remove parentheses in ($params['fixed']). Also the outside parentheses can be removed in this line and the other lines too.
There was a problem hiding this comment.
Yes, indeed. Thanks. Have found one or two other improvements as well. Commit follows.
There was a problem hiding this comment.
Turns out, some of the other improvements, were already in other PR's which have not been merged yet. It would be good to get the other improvements merged, too.
|
I have tested this item ✅ successfully on 372e0d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13238. |
|
I have tested this item ✅ successfully on 372e0d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13238. |
|
RTC after two successful tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/cms directory, which is still on hold (#12171).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.